Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Input System Package #808

Closed
ghost opened this issue Apr 23, 2021 · 5 comments
Closed

Support Input System Package #808

ghost opened this issue Apr 23, 2021 · 5 comments
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Apr 23, 2021

The current demo scene example scripts (including the debug ui) do not support the new input system which results in multiple game-breaking errors as demonstrated in the attached file.

"You are trying to read input using the UnityEngine.Input class, but you have switched active input handling to Input System package in player settings."

A solution could be providing a toggle for each script (debug UI, camera control, boat controls, etc) that can be used to switch between hard-coded input versions of each.

default controls: Input.GeyKeyDown
input system controls: Keyboard.current.space.wasPressedThisFrame

https://docs.unity3d.com/Packages/com.unity.inputsystem@1.1/manual/index.html

input.mp4
@daleeidd
Copy link
Collaborator

Thanks.

Unity provides define symbols for which input system is activated so we can support it without a toggle. For the case where both are, I think I was looking at just using the new one.

I was planning on doing this ages ago, but wanted to do it after #486 was merged (which never happened). Would you be willing to give your opinion on that proposal? I'll add support for this regardless. I'll prioritise it for 4.11.

@huwb
Copy link
Contributor

huwb commented May 1, 2021

This is still on the list, it seems to always be one or two items further down than what we have bandwidth to look at, but it is slowly bubbling up..

We're hoping to increase our bandwidth through sponsorship and i wanted to mention that once here in case there is interest in supporting us: https://github.com/sponsors/wave-harmonic

@sagron
Copy link
Contributor

sagron commented May 12, 2021

Submitted pull request #826

@daleeidd daleeidd added this to the 4.11 milestone May 23, 2021
@daleeidd
Copy link
Collaborator

Basic support has been added to resolve exceptions. Will be out with 4.11. Thanks @sagron for the PR.

@daleeidd daleeidd added Bug and removed Enhancement labels May 23, 2021
@daleeidd
Copy link
Collaborator

daleeidd commented May 31, 2021

4.11 is out so I will close this. Thanks for the help everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants