Use InputSystem when enabled in build settings #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daleeidd
requested changes
May 12, 2021
There was a problem hiding this comment.
Thanks. All of it looks great. You're just missing a couple of files to make this complete:
- Crest/Crest/Scripts/Interaction/BoatProbes.cs
- Development/Scripts/TestCameraChange.cs
- When you add the input reference to the Development asmdef, uncheck "use GUID" and ignore the GUID that is already there
|
@huwb I would like to merge this in and finish the rest in master. It is functioning as is but missed a few spots. Is this okay? |
|
Sure |
|
Thanks. And thanks @sagron for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can probably be cleaned up more using variables, but for now a straight drop-in replacement around input code that shouldn't impact existing functionality.