Add camera property to ocean renderer

[daleeidd]

Adds a camera property so that we have both viewpoint and camera.

Before we only had a viewpoint transform which could differ from the camera transform. There are times where we must use the camera like when populating the shadow data. This was a bug which @skaughtx0r reported on Discord.

We could use the main camera tag but using own property allows shadows to work with the scene camera correctly.

The viewpoint property should be kept as it still has use cases like camera zooming.

I've made ViewerHeightAboveWater sample the camera transform as I couldn't think of a reason to have that separate.

[huwb]

Looks good to me

[skaughtx0r]

Line 827 of OceanRenderer.cs should be:

Vector3 pos = Viewpoint.position;

Otherwise the ocean just follows the camera instead of the Viewpoint.

[daleeidd]

Line 827 of OceanRenderer.cs should be:

Vector3 pos = Viewpoint.position;

Otherwise the ocean just follows the camera instead of the Viewpoint.

@skaughtx0r Sorry. I couldn't see the line you are referring to. Could you check again?

[skaughtx0r]

@daleeidd Hmmm, I just checked the code in this branch and it looks fine.

I think I messed it up trying to merge this with my 2018 and PostProcessing branch.
Somehow in LateUpdatePosition() it was doing ViewCamera.transform.position.

PR looks good 👍

[huwb]

Looks great to me

[daleeidd]

Thank you both.