-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving rbac resources to Kubernetes 1.22+ #120
Conversation
thanks, verified it works @JoelSpeed can you please merge an release a new version? |
I'm no longer involved in this project, CC @icelynjennings |
@gargath ? |
Still seeing this as an issue on our side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and is needed now
Tests are still having a problem loading up dependencies for checks on this PR - looks like an environment issue? |
@aravol My 2 cents: This should be a conditional and not hard coded. Something in the line of
This way, the helm chart will work on "older" versions. Keep in mind that many enterprise kubernetes distributions are usually several versions behind. |
That was a choice not to use a conditional statement; the rbac api enetered general availability with Kubernetes 1.8.1, which has been available for nearly five years now and which has already been deprecated by most hosts |
@aravol Well, checks fail anyway -- guess it would be worth digging into that. So much to do, so little time. ;) |
Related #125 |
Bump @icelynjennings can you take a look at this? I can step in to help maintain this project if needs be; let me know! |
@icelynjennings sorry to tag you again, just wondered if this will be being merged before I make an adjustment locally. |
Ended up making the changes locally to get this working |
Consider migrate to https://github.com/stakater/Reloader Wave is not maintained anymore |
Thank you for the contribution. I will merge #112 instead of this, as it is the earlier contribution. |
Fixes #119