Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving rbac resources to Kubernetes 1.22+ #120

Closed
wants to merge 1 commit into from
Closed

Moving rbac resources to Kubernetes 1.22+ #120

wants to merge 1 commit into from

Conversation

aravol
Copy link

@aravol aravol commented Jan 21, 2022

Fixes #119

@mschneider82
Copy link

thanks, verified it works

@JoelSpeed can you please merge an release a new version?

@JoelSpeed
Copy link
Collaborator

I'm no longer involved in this project, CC @icelynjennings

@aravol
Copy link
Author

aravol commented Jan 28, 2022

@gargath ?

@aravol
Copy link
Author

aravol commented Feb 10, 2022

Still seeing this as an issue on our side

Copy link

@mcc138 mcc138 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and is needed now

@aravol
Copy link
Author

aravol commented Mar 28, 2022

Tests are still having a problem loading up dependencies for checks on this PR - looks like an environment issue?

@mwmahlberg
Copy link
Contributor

@aravol My 2 cents: This should be a conditional and not hard coded. Something in the line of

{{ if .Capabilities.KubeVersion.Minor >= 22 }}
apiVersion: rbac.authorization.k8s.io/v1
{{ else }}
apiVersion: rbac.authorization.k8s.io/v1beta1
{{ end }}

This way, the helm chart will work on "older" versions. Keep in mind that many enterprise kubernetes distributions are usually several versions behind.

@aravol
Copy link
Author

aravol commented May 26, 2022

That was a choice not to use a conditional statement; the rbac api enetered general availability with Kubernetes 1.8.1, which has been available for nearly five years now and which has already been deprecated by most hosts

@mwmahlberg
Copy link
Contributor

@aravol Well, checks fail anyway -- guess it would be worth digging into that. So much to do, so little time. ;)

@nifr
Copy link

nifr commented Jun 8, 2022

Related #125

@aaron-trout
Copy link

Bump @icelynjennings can you take a look at this? I can step in to help maintain this project if needs be; let me know!

@tw
Copy link

tw commented Aug 9, 2022

@icelynjennings sorry to tag you again, just wondered if this will be being merged before I make an adjustment locally.

@aravol
Copy link
Author

aravol commented Aug 9, 2022

Ended up making the changes locally to get this working

@mschneider82
Copy link

Consider migrate to https://github.com/stakater/Reloader

Wave is not maintained anymore

@toelke
Copy link
Collaborator

toelke commented Feb 12, 2024

Thank you for the contribution. I will merge #112 instead of this, as it is the earlier contribution.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use rbac.authorization.k8s.io/v1
10 participants