doc updates

docs/latex/doxygen.sty

@@ -27,9 +27,9 @@
   \fancyplain{}{\bfseries\thepage}%
 }
 \rfoot[\fancyplain{}{\bfseries\scriptsize%
-  Generated on Wed Jan 27 15:17:53 2010 for GDKit by Doxygen }]{}
+  Generated on Wed Jan 27 18:18:07 2010 for GDKit by Doxygen }]{}
 \lfoot[]{\fancyplain{}{\bfseries\scriptsize%
-  Generated on Wed Jan 27 15:17:53 2010 for GDKit by Doxygen }}
+  Generated on Wed Jan 27 18:18:07 2010 for GDKit by Doxygen }}
 \cfoot{}
 
 %---------- Internal commands used in this style file ----------------

docs/latex/refman.tex

@@ -41,7 +41,7 @@
 \vspace*{1cm}
 {\large Generated by Doxygen 1.6.1}\\
 \vspace*{0.5cm}
-{\small Wed Jan 27 15:17:53 2010}\\
+{\small Wed Jan 27 18:18:07 2010}\\
 \end{center}
 \end{titlepage}
 \clearemptydoublepage

examples/CrashReporter/CrashReporter.xcodeproj/project.pbxproj

@@ -973,6 +973,7 @@
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
+				DEPLOYMENT_POSTPROCESSING = NO;
 				FRAMEWORK_SEARCH_PATHS = (
 					"$(inherited)",
 					"\"$(SRCROOT)/../../build/Release\"",
@@ -983,6 +984,7 @@
 				INFOPLIST_FILE = Info.plist;
 				INSTALL_PATH = "$(HOME)/Applications";
 				PRODUCT_NAME = CrashReporter;
+				STRIP_STYLE = all;
 			};
 			name = Release;
 		};

examples/CrashReporter/Info.plist

@@ -21,7 +21,7 @@
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>108</string>
+	<string>118</string>
 	<key>LSMinimumSystemVersion</key>
 	<string>${MACOSX_DEPLOYMENT_TARGET}</string>
 	<key>NSMainNibFile</key>

examples/CrashReporter/versioning/version

@@ -1,4 +1,4 @@
 0
 0
 0
-108
+118

gdkit.xcodeproj/project.pbxproj

@@ -959,6 +959,7 @@
 				COPY_PHASE_STRIP = YES;
 				CURRENT_PROJECT_VERSION = 1;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
+				DEPLOYMENT_POSTPROCESSING = NO;
 				DYLIB_COMPATIBILITY_VERSION = 1;
 				DYLIB_CURRENT_VERSION = 1;
 				FRAMEWORK_VERSION = 1;
@@ -981,6 +982,7 @@
 				PRODUCT_NAME = GDKit;
 				RUN_CLANG_STATIC_ANALYZER = YES;
 				SKIP_INSTALL = YES;
+				STRIP_STYLE = debugging;
 				VALID_ARCHS = "i386 ppc ppc64 x86_64";
 				ZERO_LINK = NO;
 			};

python/sendcrashreport.py

@@ -33,9 +33,9 @@
 	if not os.path.exists(corefile): exit(0)
 	if comments and not os.path.exists(comments): comments=False
 	msg=MIMEMultipart()
-	msg['From']="FROM_EMAIL"
-	msg['To']="TO_EMAIL"
-	msg['Subject']="SUBJECT"
+	msg['From']="gitybot@macendeavor.com"
+	msg['To']="support@macendeavor.com"
+	msg['Subject']="GityBot: Crash Report"
 	if comments: msg.attach(MIMEText( open(comments,"r").read() ))
 	else: msg.attach(MIMEText(" "))
 	part=MIMEBase('application','octet-stream')
@@ -47,8 +47,8 @@
 	mailServer.ehlo()
 	mailServer.starttls()
 	mailServer.ehlo()
-	mailServer.login('EMAIL','PASS')
-	mailServer.sendmail('FROM_EMAIL','TO_EMAIL',msg.as_string())
+	mailServer.login('gitybot@macendeavor.com','dl49ope093ld98')
+	mailServer.sendmail('gitybot@macendeavor.com','support@macendeavor.com',msg.as_string())
 	mailServer.close()
 	if comments: os.unlink(comments)
 except Exception,e:

source/GDASLLog.m

@@ -92,7 +92,7 @@ - (void) warning:(NSString *) message {
 }
 
 - (void) close {
-	asl_remove_log_file(client,fd);
+	if(fd>0)asl_remove_log_file(client,fd);
 	asl_close(client);
 }
 

source/GDCrashReporter.h

@@ -10,17 +10,9 @@
  * Header file for GDCrashReporter.
  */
 
-/**
- * The GDExternalNibController is a controller used to manage
- * an external nib. It has shortcuts for showing the nib, or showing
- * it as a sheet, and can auto dispose of the nib resources when
- * it's closed.
- */
-
 /**
  * The GDCrashReporter is a controller that implements post-trauma-pre-usage
  * crash reporting.
- *
  */
 @interface GDCrashReporter : NSObject {
 	BOOL hasCrash;
@@ -86,6 +78,9 @@
  */
 @property (copy,nonatomic) NSString * companyName;
 
+/**
+ * Whether or not the crash report should be deleted after it's reported.
+ */
 @property (assign,nonatomic) BOOL deleteCrashReport;
 
 /**

source/GDCrashReporter.m

@@ -28,6 +28,7 @@ - (id) initWithUserDefaultsPrefix:(NSString *) _prefix {
 
 - (void) forceCrash {
 	signal(SIGBUS,SIG_DFL);
+	//*(long*)0 = 0xDEADBEEF;
 	abort();
 }
 
@@ -82,7 +83,7 @@ - (void) searchForCrashReports {
 		files = [fman contentsOfDirectoryAtPath:path error:nil];
 		if(files and [files count]>0) {
 			for(file in files) {
-				if([file hasPrefix:app]){
+				if([file hasPrefix:app]) {
 					fullPath = [path stringByAppendingPathComponent:file];
 					attributes = [fman attributesOfItemAtPath:fullPath error:nil];
 					if(!attributes) continue;
@@ -146,7 +147,7 @@ - (void) addCrashSearchPath:(NSString *) _searchPath {
 	if(!_searchPath) return;
 	NSString * c = [_searchPath copy];
 	[searchPaths addObject:c];
-	[c release]; 
+	[c release];
 }
 
 - (void) _deleteCrashReport {
@@ -158,7 +159,7 @@ - (IBAction) onsend:(id) sender {
 	[window orderOut:nil];
 	NSString * pyc;
 	NSBundle * mb = [NSBundle bundleForClass:[self class]];
-	if(task) [task terminate];
+	if(task and [task isRunning]) [task terminate];
 	GDRelease(task);
 	task = [[NSTask alloc] init];
 	NSMutableArray * args = [[NSMutableArray alloc] init];
@@ -169,7 +170,7 @@ - (IBAction) onsend:(id) sender {
 	if(!pyc)pyc=[mb pathForResource:@"sendcrashreport" ofType:@"pyc" inDirectory:@"Scripts"];
 	[args addObject:pyc];
 	[args addObject:[@"-f " stringByAppendingString:crashFile]];
-	if([comms length] > 0 && ![comms isEqual:@"Optionally provide any details you can to replicate the crash"]) {
+	if([comms length] > 0 && ![comms isEqual:placeHolderComm]) {
 		NSString * tmpFileName = [NSFileHandle tmpFileName];
 		NSFileHandle * tmp = [NSFileHandle tmpFile:tmpFileName];
 		NSData * cdata = [comms dataUsingEncoding:NSUTF8StringEncoding];
@@ -208,6 +209,7 @@ - (void) dealloc {
 	#endif
 	hasCrash=false;
 	GDRelease(placeHolderComm);
+	if(task and [task isRunning]) [task terminate];
 	GDRelease(task);
 	GDRelease(searchPaths);
 	GDRelease(userDefaultsPrefix);