Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archiving/distributing #23

Closed
blippy opened this issue Jan 26, 2016 · 6 comments
Closed

Archiving/distributing #23

blippy opened this issue Jan 26, 2016 · 6 comments

Comments

@blippy
Copy link

blippy commented Jan 26, 2016

The following issues were noted upon releasing 1.4.0:

@milancurcic said "make dist failed to install CONTRIBUTORS, README.md and LICENSE."

My response: I agree. I will look into this.

@zbeekman said "If you can find a way to get make dist to package the missing markdown files, you can just manually add the tarball generated by make dist as a release asset."

Yes. I think it is easy enough for me to do this.

I note additional packaging problems:

  • git creates archives based on what is checked into the repo, which unfortunately does not include configure
  • there can be mismatches between the version numbers in tags, the configure.ac file, and what's in src/lib/datetime.f90

I will look into these issues. If anyone has a good anser to this, then let me know.

@blippy blippy mentioned this issue Jan 26, 2016
Merged
@blippy
Copy link
Author

blippy commented Jan 26, 2016

The discussion above originally referenced in #22 (comment)

@blippy
Copy link
Author

blippy commented Jan 26, 2016

@zbeekman also references the version mismatching at d49af9e#commitcomment-15688257

@blippy
Copy link
Author

blippy commented Jan 27, 2016

@milancurcic said "make dist failed to install CONTRIBUTORS, README.md and LICENSE."

Fixed by:
https://github.com/blippy/datetime-fortran/commit/20e9709a16e7e7dadde8a7aac5e3008f700b726b

@blippy
Copy link
Author

blippy commented Jan 27, 2016

Added some consistency checking of versioning when you '''make dist'''. Making the distribution will fail if those checks are not satisified.

See pull request: #26

Once patched, I think this issue can be closed.

@milancurcic
Copy link
Member

I played a bit more with the make dist. See the files that come out of the tarball:

$ tar xzvf datetime-fortran-1.4.0.tar.gz 
datetime-fortran-1.4.0/
datetime-fortran-1.4.0/INSTALL
datetime-fortran-1.4.0/configure
datetime-fortran-1.4.0/Makefile.am
datetime-fortran-1.4.0/scrub-clean.sh
datetime-fortran-1.4.0/src/
datetime-fortran-1.4.0/src/tests/
datetime-fortran-1.4.0/src/tests/datetime_tests.f90
datetime-fortran-1.4.0/src/tests/Makefile.am
datetime-fortran-1.4.0/src/tests/Makefile.in
datetime-fortran-1.4.0/src/lib/
datetime-fortran-1.4.0/src/lib/mod_datetime.f90
datetime-fortran-1.4.0/src/lib/mod_strftime.f90
datetime-fortran-1.4.0/src/lib/Makefile.am
datetime-fortran-1.4.0/src/lib/mod_timedelta.f90
datetime-fortran-1.4.0/src/lib/mod_clock.f90
datetime-fortran-1.4.0/src/lib/Makefile.in
datetime-fortran-1.4.0/src/lib/mod_constants.f90
datetime-fortran-1.4.0/src/lib/datetime.f90
datetime-fortran-1.4.0/src/lib/datetime_module.mod
datetime-fortran-1.4.0/install-sh
datetime-fortran-1.4.0/Makefile.in
datetime-fortran-1.4.0/CONTRIBUTORS
datetime-fortran-1.4.0/mkdist.sh
datetime-fortran-1.4.0/configure.ac
datetime-fortran-1.4.0/aclocal.m4
datetime-fortran-1.4.0/datetime-fortran.pc.in
datetime-fortran-1.4.0/README.md
datetime-fortran-1.4.0/LICENSE
datetime-fortran-1.4.0/AUTHORS
datetime-fortran-1.4.0/missing

The datetime_module.mod shouldn't be in there. Is this easy to amend?

@blippy
Copy link
Author

blippy commented Jan 29, 2016

It looks as if all issues here are addressed, so I'll close it.

Raise a separate issue if necessary.

@blippy blippy closed this as completed Jan 29, 2016
milancurcic added a commit that referenced this issue Jan 29, 2016
Fixed issue #23 : The datetime_module.mod shouldn't be in there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants