Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use case insensitive scan for script type attribute WaveDrom #343

Open
stou opened this issue Oct 27, 2021 · 0 comments
Open

Use case insensitive scan for script type attribute WaveDrom #343

stou opened this issue Oct 27, 2021 · 0 comments

Comments

@stou
Copy link

stou commented Oct 27, 2021

Tested with https://cdnjs.cloudflare.com/ajax/libs/wavedrom/2.6.8/wavedrom.min.js" type="text/javascript

HTML attributes are case insensitive, thus the scan for the type attribute of the script tag should be case insensitive.
Using the version <script type="WaveDrom"></script>, can cause problems when feed through a minification process of html generated from markdown.
E.g. by embedding in a hugo (https://gohugo.io/) based blog.
stou pushed a commit to stou/wavedrom that referenced this issue Oct 27, 2021
Use case insensitive scan for script type attribute WaveDrom (issue w…
5f568cf 
…avedrom#343)

Fix for issue wavedrom#343

HTML attributes are case insensitive, thus the scan for the type attribute of the script tag should be case insensitive.
Using the version <script type="WaveDrom"></script>, can cause problems when feed through a minification process of html generated from markdown.
E.g. by embedding in a hugo (https://gohugo.io/) based blog.
@stou stou mentioned this issue Oct 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stou