Skip to content
This repository has been archived by the owner on Dec 8, 2023. It is now read-only.

Memory improvements #75

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Memory improvements #75

merged 3 commits into from
Sep 23, 2020

Conversation

vikramraman
Copy link
Contributor

@vikramraman vikramraman commented Sep 21, 2020

  • Fixed a memory leak in the rate calculator (we were holding onto deleted pods/containers forever). We now prune the internal cache every 5 minutes.
  • Tweaked the discovery mechanism to kick off discovery only if pods/services are ready (IPs assigned and running). This reduces allocations & cpu usage in high churn environments.

@vikramraman vikramraman added this to the 1.2.4 milestone Sep 22, 2020
Copy link
Contributor

@laullon laullon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikramraman vikramraman merged commit 17a02e2 into master Sep 23, 2020
@vikramraman vikramraman deleted the vikramr/rate_memory_leak branch September 23, 2020 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants