Append error tag to the histogram of duration (#74)

* Append error tag to the histogram of duration * Use seperate map
wavefrontHQ · Aug 26, 2019 · 98c3869 · 98c3869
1 parent 8918c26
commit 98c3869
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/main/java/com/wavefront/opentracing/WavefrontTracer.java b/src/main/java/com/wavefront/opentracing/WavefrontTracer.java
@@ -298,8 +298,15 @@ void reportWavefrontGeneratedData(WavefrontSpan span) {
     wfDerivedReporter.newCounter(new MetricName(sanitize(metricNamePrefix + TOTAL_TIME_SUFFIX),
         pointTags)).inc(spanDurationMicros / 1000);
     // Support duration in microseconds instead of milliseconds
-    wfDerivedReporter.newWavefrontHistogram(new MetricName(sanitize(metricNamePrefix + DURATION_SUFFIX),
-        pointTags)).update(spanDurationMicros);
+    if (span.isError()) {
+      Map<String, String> errorPointTags = new HashMap<>(pointTags);
+      errorPointTags.put("error", "true");
+      wfDerivedReporter.newWavefrontHistogram(new MetricName(sanitize(metricNamePrefix + DURATION_SUFFIX),
+          errorPointTags)).update(spanDurationMicros);
+    } else {
+      wfDerivedReporter.newWavefrontHistogram(new MetricName(sanitize(metricNamePrefix + DURATION_SUFFIX),
+          pointTags)).update(spanDurationMicros);
+    }
   }
 
   private String overrideWithSingleValuedSpanTag(WavefrontSpan span, Map<String, String> pointTags,