Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONIT-15154: Phase 2 - switch to new backend API (do not merge) #406

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

basilisk487
Copy link
Contributor

No description provided.

@basilisk487 basilisk487 changed the title Backend API change MONIT-15154: Phase 2 - switch to new backend API (do not merge) Jul 13, 2019
Copy link
Contributor

@jbau jbau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It looks like the APIs got somewhat simpler (less parameters), which is alway nice.

Guess someone should test v2 proxy -> v2 backend as well as v1 proxy -> v1 backend. how should that happen?

@@ -0,0 +1,94 @@
package com.wavefront.api;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this file is basically a copy-paste

@@ -801,8 +768,32 @@ public Response setDescription(String id, String desc, boolean forceToQueue) {
}

@Override
public Response removeTag(String id, String tagValue, boolean forceToQueue) {
public Response appendTag(String id, String tagValue, boolean forceToQueue) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess we picked up appendTag as a new API method

@basilisk487 basilisk487 merged commit 9d6fa0c into master Aug 21, 2019
@basilisk487 basilisk487 deleted the monit-15154 branch April 4, 2020 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants