Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SpanLogsDecoder to decode spanSecondaryId #437

Merged
merged 3 commits into from
Aug 20, 2019

Conversation

hanwavefront
Copy link
Contributor

No description provided.

Copy link
Contributor

@basilisk487 basilisk487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test covering the actual usage of spanSecondaryId would be nice

Copy link
Contributor

@basilisk487 basilisk487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@basilisk487 basilisk487 merged commit 8a51c74 into master Aug 20, 2019
@basilisk487 basilisk487 deleted the han/decode-spansecondaryid branch April 4, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants