Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote span.kind as RED metrics #500

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Promote span.kind as RED metrics #500

merged 1 commit into from
Feb 21, 2020

Conversation

yzheqing
Copy link
Contributor

  1. This PR allows the custom tag filter span.kind, to appear on P0/P1 application status page. The dropdown menu under span.kind contains the value of client, server or unknown (by default).
  2. Tested with Jaeger/Zipkin integration: span data being sent through wavefront proxy can be filtered on P0/P1 through span.kind dropdown menu.

@yzheqing yzheqing self-assigned this Feb 20, 2020
hanwavefront
hanwavefront suggested changes Feb 20, 2020
View reviewed changes
proxy/config.ini Outdated Show resolved Hide resolved
hanwavefront
hanwavefront approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@hanwavefront hanwavefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yzheqing yzheqing changed the title MONIT-17870: Promote span.kind as RED metrics Promote span.kind as RED metrics Feb 21, 2020
sushantdewan123
sushantdewan123 approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@sushantdewan123 sushantdewan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sushantdewan123 sushantdewan123 merged commit 6dfb15d into master Feb 21, 2020
@yzheqing yzheqing deleted the yzheqing/MONIT-17870 branch February 21, 2020 16:49
yzheqing added a commit that referenced this pull request Feb 26, 2020
@yzheqing
Promote span.kind as RED metrics (#500)
0144ab5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushantdewan123 sushantdewan123 sushantdewan123 approved these changes

@hanwavefront hanwavefront hanwavefront approved these changes

Assignees

@yzheqing yzheqing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yzheqing @sushantdewan123 @hanwavefront