Add content on custom tracing port #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @srujann The doc link is broken for now until the changes get pushed to mater. |
srujann
reviewed
Jun 16, 2020
README.md
Outdated
| Depending on the data you wish to send to Wavefront (metrics, distributions (histograms) and/or spans), enable the relevant ports on the proxy and initialize the proxy sender as follows: | ||
| Depending on the data you wish to send to Wavefront (metrics, distributions (histograms) and/or spans), enable the relevant ports on the proxy and initialize the proxy sender. | ||
|
|
||
| When you use a Sender SDK, you won’t see span-level RED metrics by default unless you use the Wavefront proxy and define a custom tracing port (`tracingPort`). See [Instrument Your Application with Wavefront Sender SDKs](https://www.wavefront.com/tracing_instrumenting_frameworks.html/#instrument-your-application-with-wavefront-sender-sdks) for details. |
There was a problem hiding this comment.
add a subsection title that this is related to sending spans.
There was a problem hiding this comment.
Thank you! There was a tracing span subsection. I moved it there.
vikramraman
reviewed
Jun 17, 2020
README.md
Outdated
| @@ -266,6 +265,8 @@ sender.SendDistribution("request.latency", centroids, hgs, 0, "appServer1", map[ | |||
|
|
|||
| #### Tracing Spans | |||
|
|
|||
| When you use a Sender SDK, you won’t see span-level RED metrics by default unless you use the Wavefront proxy and define a custom tracing port (`TracingPort`). See [Instrument Your Application with Wavefront Sender SDKs](https://www.wavefront.com/tracing_instrumenting_frameworks.html/#instrument-your-application-with-wavefront-sender-sdks) for details. | |||
There was a problem hiding this comment.
the given link doesn't work?
There was a problem hiding this comment.
Thank you! Fixed. :)
vikramraman
approved these changes
Jun 17, 2020
laullon
added a commit
that referenced
this pull request
Jun 30, 2020
* master: Add content on custom tracing port (#56) Update the README.MD file (#54) speed up histo tests (#53) clarify 64-bit misalignment Align LineHandler struct fields to allow atomic access (#52) tweak source formatting Enhance the wavefront-sdk-go to support Kubernetes environments (#47) # Conflicts: # application/application.go # internal/formatter.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add content on custom tracing port.