Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed (try to) duplicate modes and missing modes for large MMFs
Problem identified:
It found beta values outside the range where the cost function changed sign(!)
This was due not resetting the value of r_max where we estimate the field far away that should converge to zero.
r_max was lowered for low order modes, that have a small size and for which the far field value estimation was not numerically stable.
As r_max was not put back to the original (higher) value. for high order modes, there was still some oscillations, so the sign was not the same as the first estimation.
Solution:
r_max
value tor_max0
r_max = r_max0