Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radial issues #8

Merged
merged 4 commits into from Nov 22, 2023
Merged

Radial issues #8

merged 4 commits into from Nov 22, 2023

Conversation

wavefrontshaping
Copy link
Owner

Fixed (try to) duplicate modes and missing modes for large MMFs

Problem identified:

It found beta values outside the range where the cost function changed sign(!)
This was due not resetting the value of r_max where we estimate the field far away that should converge to zero.
r_max was lowered for low order modes, that have a small size and for which the far field value estimation was not numerically stable.
As r_max was not put back to the original (higher) value. for high order modes, there was still some oscillations, so the sign was not the same as the first estimation.

Solution:

  • Rename the initial r_max value to r_max0
  • In the loop over the m values, add r_max = r_max0

@wavefrontshaping wavefrontshaping merged commit f9cf46a into master Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant