Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: improper checking for index and size for arrays #15

Closed
lukas-gor opened this issue Nov 30, 2018 · 2 comments
Closed

Bug: improper checking for index and size for arrays #15

lukas-gor opened this issue Nov 30, 2018 · 2 comments
Assignees
@cardil
Labels
bug
Milestone
v2.0.0

Comments

@lukas-gor
Copy link

java-eid-exceptions/src/main/java/pl/wavesoftware/eid/utils/EidPreconditions.java

Line 400 in e4015c4

return index < 0 || index > size;

I think, it should be return index < 0 || index >= size;
@cardil
Copy link
Member

cardil commented Nov 30, 2018

Thanks for bug report. I will investigate that.

@cardil cardil changed the title Bug Bug: improper checking for index and size for arrays Nov 30, 2018
@cardil cardil self-assigned this Nov 30, 2018
@cardil cardil added this to the v2.0.0 milestone Nov 30, 2018
cardil added a commit that referenced this issue Nov 30, 2018
@cardil
Bugfix #15: proper checking for index and size for arrays
d99cc3d
cardil added a commit that referenced this issue Dec 3, 2018
@cardil
Bugfix #15: proper checking for index and size for arrays
67c1ca6
@cardil cardil added the bug label Dec 4, 2018
@cardil
Copy link
Member

cardil commented Dec 18, 2018

Fixed on PR #6

Will be released as v2.0.0

@cardil cardil closed this as completed Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cardil cardil

Labels
bug
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@cardil @lukas-gor