allow @ symbol in user for ssh connections #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the @ symbol was only used as a way to either: - separate the user from the host - separate "sudo" from the user This change expands this to allow the username part of sudo@username@host or username@host to contain any number of @ symbols in addition to the ones previously allowed. Host is not allowed to contain an @ symbol as per the usual definition.
Moved the dash in the regex pattern to the end to make it explicitly clear that it isn't part of a range. Removed the hostNameRe regex as it is unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #127 raised the issue that user in (user@host) was previously not allowed to contain @ symbols. This change modifies the regex to allow it.
Note that this does not interfere with the previous sudo@ prefix since this can still be parsed separately. As host is not allowed to contain an @ symbol, we allow any number of @ symbols as part of the user.