Fix null length

wavevision · Nov 7, 2019 · c0f93a7 · c0f93a7
1 parent 0771923
commit c0f93a7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/DoctrineEntityFaker/ConfigurationFactory.php b/src/DoctrineEntityFaker/ConfigurationFactory.php
@@ -32,11 +32,11 @@ public function create(): Configuration
 				return $faker->dateTime;
 			},
 			Types::STRING => function (Column $column) use ($faker) {
-				$length = $column->length;
+				$length = $column->length ?? 255;
 				if ($length <= 10) {
 					return substr(md5((string)mt_rand()), 0, $length);
 				}
-				return $faker->text($column->length ?? 255);
+				return $faker->text($length);
 			},
 			Types::TEXT => function () use ($faker) {
 				return $faker->text();

diff --git a/tests/DoctrineEntityFakerTests/Entities/EntityB.php b/tests/DoctrineEntityFakerTests/Entities/EntityB.php
@@ -44,6 +44,12 @@ class EntityB
 	 */
 	public $string;
 
+	/**
+	 * @var string
+	 * @ORM\Column(type="string")
+	 */
+	public $stringDefaultLength;
+
 	/**
 	 * @var string
 	 * @ORM\Column(type="string", length=2)