Remove todo

src/NamespaceTranslator/Loaders/TranslationClass/GetTranslationArray.php

@@ -5,6 +5,7 @@
 use Nette\SmartObject;
 use PhpParser\Node\Expr\Array_;
 use Wavevision\DIServiceAnnotation\DIService;
+use Wavevision\NamespaceTranslator\Exceptions\InvalidState;
 
 /**
  * @DIService(generateInject=true)
@@ -19,9 +20,11 @@ public function process(string $resource): Array_
 	{
 		$returnFinder = new ReturnFinder();
 		$this->traverseFileAst->process($resource, $returnFinder);
-		/** @var Array_ $array */
 		$array = $returnFinder->getReturn()->expr;
-		return $array;
+		if ($array instanceof Array_) {
+			return $array;
+		}
+		throw new InvalidState('Define function must return an array.');
 	}
 
 }

src/NamespaceTranslator/Loaders/TranslationClass/ReturnFinder.php

@@ -7,6 +7,7 @@
 use PhpParser\Node\Stmt\Return_;
 use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitorAbstract;
+use Wavevision\NamespaceTranslator\Exceptions\InvalidState;
 
 class ReturnFinder extends NodeVisitorAbstract
 {
@@ -18,21 +19,31 @@ class ReturnFinder extends NodeVisitorAbstract
 	 */
 	public function leaveNode(Node $node)
 	{
-		//todo validate single return
 		if ($node instanceof ClassMethod) {
+			if ($node->name->name !== 'define') {
+				throw new InvalidState("TranslationClass must contains function 'define'.");
+			}
+			if (!($node->isStatic() && $node->isPublic())) {
+				throw new InvalidState('Define function must be public and static.');
+			}
 			$stmts = $node->getStmts();
-			if (isset($stmts[0])) {
+			if (isset($stmts[0]) && count($stmts) === 1) {
 				/** @var Return_ $return */
 				$return = $stmts[0];
 				$this->return = $return;
+			} else {
+				throw new InvalidState('Define function must have exactly one statement.');
 			}
 			return NodeTraverser::STOP_TRAVERSAL;
 		}
 	}
 
 	public function getReturn(): Return_
 	{
-		return $this->return;
+		if (isset($this->return)) {
+			return $this->return;
+		}
+		throw new InvalidState('No class method found.');
 	}
 
 }

src/NamespaceTranslator/Transfer/Export/FileSetFactory.php

@@ -33,8 +33,7 @@ public function create(string $directory, Loader $loader, string $format): Trans
 			/** @var SplFileInfo $file */
 			foreach (Finder::findFiles('*' . $suffix)->in($translationDirectory) as $file) {
 				$pathname = $file->getPathname();
-				//todo replace rtrim
-				$basePathname = str_replace($suffix, '', $pathname);
+				$basePathname = substr_replace($pathname, '', -strlen($suffix));
 				$translations->add(
 					new FileSet(
 						$this->fileSet($basePathname, $loader),

tests/NamespaceTranslatorTests/Loaders/TranslationClass/GetTranslationArrayTest.php

@@ -0,0 +1,57 @@
+<?php declare(strict_types = 1);
+
+namespace Wavevision\NamespaceTranslatorTests\Loaders\TranslationClass;
+
+use Nette\SmartObject;
+use PhpParser\Node\Expr\Array_;
+use Wavevision\NamespaceTranslator\Exceptions\InvalidState;
+use Wavevision\NamespaceTranslator\Loaders\TranslationClass\InjectGetTranslationArray;
+use Wavevision\NetteTests\TestCases\DIContainerTestCase;
+
+class GetTranslationArrayTest extends DIContainerTestCase
+{
+
+	use SmartObject;
+	use InjectGetTranslationArray;
+
+	public function test(): void
+	{
+		$this->assertInstanceOf(
+			Array_::class,
+			$this->getTranslationArray->process(__DIR__ . '/../../App/Models/Translated/Translations/Cs.php')
+		);
+	}
+
+	public function testMissingDefine(): void
+	{
+		$this->exception(__DIR__ . '/Resources/InvalidName.php', "TranslationClass must contains function 'define'.");
+	}
+
+	public function testMissingFlags(): void
+	{
+		$this->exception(__DIR__ . '/Resources/InvalidFlags.php', "Define function must be public and static.");
+	}
+
+	public function testInvalidReturn(): void
+	{
+		$this->exception(__DIR__ . '/Resources/InvalidReturn.php', "Define function must return an array.");
+	}
+
+	public function testInvalidBody(): void
+	{
+		$this->exception(__DIR__ . '/Resources/InvalidBody.php', "Define function must have exactly one statement.");
+	}
+
+	public function testNoFunction(): void
+	{
+		$this->exception(__DIR__ . '/Resources/NoMethod.php', 'No class method found.');
+	}
+
+	private function exception(string $file, string $message): void
+	{
+		$this->expectException(InvalidState::class);
+		$this->expectExceptionMessage($message);
+		$this->getTranslationArray->process($file);
+	}
+
+}

tests/NamespaceTranslatorTests/Loaders/TranslationClass/Resources/InvalidBody.php

@@ -0,0 +1,17 @@
+<?php declare(strict_types = 1);
+
+namespace Wavevision\NamespaceTranslatorTests\Loaders\TranslationClass\Resources;
+
+class InvalidBody
+{
+
+	/**
+	 * @return array<mixed>
+	 */
+	public static function define(): array
+	{
+		$a = 'hello';
+		return [$a => $a];
+	}
+
+}

tests/NamespaceTranslatorTests/Loaders/TranslationClass/Resources/InvalidFlags.php

@@ -0,0 +1,16 @@
+<?php declare(strict_types = 1);
+
+namespace Wavevision\NamespaceTranslatorTests\Loaders\TranslationClass\Resources;
+
+class InvalidFlags
+{
+
+	/**
+	 * @return array<mixed>
+	 */
+	public function define(): array
+	{
+		return [];
+	}
+
+}

tests/NamespaceTranslatorTests/Loaders/TranslationClass/Resources/InvalidName.php

@@ -0,0 +1,16 @@
+<?php declare(strict_types = 1);
+
+namespace Wavevision\NamespaceTranslatorTests\Loaders\TranslationClass\Resources;
+
+class InvalidName
+{
+
+	/**
+	 * @return array<mixed>
+	 */
+	public static function hello(): array
+	{
+		return [];
+	}
+
+}

tests/NamespaceTranslatorTests/Loaders/TranslationClass/Resources/InvalidReturn.php

@@ -0,0 +1,13 @@
+<?php declare(strict_types = 1);
+
+namespace Wavevision\NamespaceTranslatorTests\Loaders\TranslationClass\Resources;
+
+class InvalidReturn
+{
+
+	public static function define(): string
+	{
+		return '';
+	}
+
+}

tests/NamespaceTranslatorTests/Loaders/TranslationClass/Resources/NoMethod.php

@@ -0,0 +1,8 @@
+<?php declare(strict_types = 1);
+
+namespace Wavevision\NamespaceTranslatorTests\Loaders\TranslationClass\Resources;
+
+class NoMethod
+{
+
+}