chore: allow pass row fd to capture #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decodetalkers
force-pushed
the
addcapturefd
branch
from
9df5ba2
to
96279f7
Compare
Decodetalkers
commented
Aug 15, 2023
Decodetalkers
force-pushed
the
addcapturefd
branch
2 times, most recently
from
600384b
to
dcf908e
Compare
|
let me test it weather it will work |
Decodetalkers
force-pushed
the
addcapturefd
branch
11 times, most recently
from
1fc366a
to
6d8da4f
Compare
Decodetalkers
force-pushed
the
addcapturefd
branch
2 times, most recently
from
258a243
to
4eb2552
Compare
|
https://github.com/waycrate/wayshot/assets/60290287/a1b81cc8-aea9-4401-8f0e-78733a95fed6 |
Decodetalkers
force-pushed
the
addcapturefd
branch
from
4eb2552
to
c8624d4
Compare
|
I think this need #59 , we need to bind wloutput first, and wloutput dispatch too much time, then I can continue to work on screencast, thanks to xdg-desktop-portal-cosmic |
Decodetalkers
force-pushed
the
addcapturefd
branch
2 times, most recently
from
b0afb1f
to
5d49d85
Compare
Decodetalkers
force-pushed
the
addcapturefd
branch
from
5d49d85
to
03d33bc
Compare
|
ok , it still works fine |
|
https://github.com/Decodetalkers/gstreamer_train/blob/pipewiretest2/src/pipewirethread.rs#L57 you can try this branch, it wll successfully make a screencast |
Decodetalkers
force-pushed
the
addcapturefd
branch
from
03d33bc
to
196aa5b
Compare
Decodetalkers
force-pushed
the
addcapturefd
branch
from
cd4e802
to
fc1904b
Compare
Shinyzenith
requested changes
Aug 21, 2023
Co-authored-by: Aakash Sen Sharma <60808802+Shinyzenith@users.noreply.github.com>
fix error of NosupportedFormat Co-authored-by: Aakash Sen Sharma <60808802+Shinyzenith@users.noreply.github.com>
fix catpure_output_frame_shm_fd commit Co-authored-by: Aakash Sen Sharma <60808802+Shinyzenith@users.noreply.github.com>
Shinyzenith
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/pop-os/xdg-desktop-portal-cosmic/blob/master_jammy/src/wayland.rs#L191
from the code in xdg-desktop-portal-cosmis, here should pass a rawfd to it , so maybe expose a function is better?