Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDR upscaling is not always not enabled after launching the app the first time - have to open twice. #1158

Closed
DunhamGitHub opened this issue Nov 16, 2022 · 8 comments
Assignees
Labels
bug Something isn't working done All tasks are completed released Released XDR/HDR/upscaling XDR, HDR and brightness upscaling related features
Milestone

Comments

@DunhamGitHub
Copy link

Ventura 13.01

On first open (after wake from sleep or reboot)

image

Then have to quit, open again 馃憠馃徎
image

@waydabber waydabber added the investigating Investigating issue label Nov 16, 2022
@waydabber
Copy link
Owner

Thanks, I'll take a look at this one.

A few questions:

  • Are you using v1.3.5-beta or v1.3.4?
  • When works, then if you close the app, wait for a while and open it, will the issue arise?
  • If you wait after boot or sleep for a while while the app is not running and then start up the app manually, do you experience the same?

@DunhamGitHub
Copy link
Author

a. 1.3.4
b. Will report back if I have time to test
c. If I open the app after 5-10 minutes, same issue

@waydabber
Copy link
Owner

Thank you, I'll try to reproduce it and figure out what's wrong!

@waydabber waydabber added the bug Something isn't working label Nov 17, 2022
@waydabber waydabber self-assigned this Nov 17, 2022
@DunhamGitHub
Copy link
Author

b. I had it closed almost 1h, yes, on reopen it again shows max = 100% (cannot go past, have to quit + open again)

@waydabber
Copy link
Owner

so basically every time you start up the app, it does not work but once you start it up again, it does work. That's the universal pattern, right?

@DunhamGitHub
Copy link
Author

Everytime too much time passes and I open the app again it only shows 100%, then have to reopen.

Which would be a 99% "yes" to your question I rekon 馃

@waydabber
Copy link
Owner

Just want to let you know that I was able to reproduce the issue. It is baffling, but I will figure it out and fix it!

@waydabber waydabber added in progress Implementing unreleased Not released yet in beta form and removed investigating Investigating issue labels Nov 19, 2022
@waydabber waydabber added this to the v1.3.6 milestone Nov 19, 2022
@waydabber
Copy link
Owner

Ok, found the problem and fixed it. Thanks for bringing this up!

I'd have never find it by myself as it is related to how quickly the app is configuring the displays and apparently if native smooth scaling is enabled for the internal display (which due to the high number of modes will just slightly slow down initial configuration so that HDR upscaling has time to set up) the problem does not present itself. Since I have that feature enabled (I think you should try it too, it works great for the internal display on the MBP 14"), I did not encounter this problem.

@waydabber waydabber added done All tasks are completed and removed in progress Implementing labels Nov 19, 2022
@waydabber waydabber changed the title Ventura, have to open twice. First open 100% display brightness is max (M14pro) XDR upscaling is not always not enabled after launching the app the first time - have to open twice. Nov 19, 2022
@waydabber waydabber added released Released and removed unreleased Not released yet in beta form labels Nov 20, 2022
@waydabber waydabber added the XDR/HDR/upscaling XDR, HDR and brightness upscaling related features label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done All tasks are completed released Released XDR/HDR/upscaling XDR, HDR and brightness upscaling related features
Projects
None yet
Development

No branches or pull requests

2 participants