Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update combined brightness slider/keyboard control state for Apple screens when brightness is changed outside of the app #602

Closed
waydabber opened this issue May 23, 2022 · 2 comments
Assignees
Labels
done All tasks are completed enhancement New feature or request pre-release feedback Feedack for a pre-release version released Released
Milestone

Comments

@waydabber
Copy link
Owner

waydabber commented May 23, 2022

When combined brightness control is enabled, system level (ambient sensor, touchbar, mission control) panel brightness changes are not reflected in the current state - this results in an unexpected brightness change when the user adjusts the brightness via keyboard or slider.

@waydabber waydabber added bug Something isn't working pre-release feedback Feedack for a pre-release version labels May 23, 2022
@waydabber waydabber added this to the v1.2.4 milestone May 23, 2022
@waydabber waydabber self-assigned this May 23, 2022
@waydabber
Copy link
Owner Author

This is a rather tricky problem as combined brightness will (or can) involve both sub-zero-hardware dimming and above-max-hardware XDR upscale for Apple screens so there must be some kind of tradeoff. Apple brightness levels will only replicate to the combined sliders if the slider is inside the minimum and maximum hardware level range (this is currently 20%->100% for Apple displays).

@waydabber waydabber added enhancement New feature or request done All tasks are completed unreleased Not released yet in beta form and removed bug Something isn't working labels May 25, 2022
@waydabber
Copy link
Owner Author

waydabber commented May 25, 2022

I built an elaborate logic to handle this. Obviously macOS scales will influence hardware brightness only, this is properly replicated to the combined hardware brightness slider, if needed software adjustments and upscaling also gradually moves to the appropriate level so the resulting experience is a quite smooth one.

@waydabber waydabber added pre-release available Released as beta version and removed unreleased Not released yet in beta form labels Jun 2, 2022
@waydabber waydabber added released Released and removed pre-release available Released as beta version labels Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done All tasks are completed enhancement New feature or request pre-release feedback Feedack for a pre-release version released Released
Projects
None yet
Development

No branches or pull requests

1 participant