Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brightness keyboard shortcuts should not affect dummy screens directly but only non-dummy mirror or stream target displays #616

Closed
waydabber opened this issue May 26, 2022 · 1 comment
Closed

Brightness keyboard shortcuts should not affect dummy screens directly but only non-dummy mirror or stream target displays #616

waydabber opened this issue May 26, 2022 · 1 comment
Assignees
@waydabber
Labels
bug Something isn't working done All tasks are completed PIP/Stream PIP or full screen streaming pre-release feedback Feedack for a pre-release version released Released
Milestone
v1.2.4

Comments

@waydabber
Copy link
Owner

waydabber commented May 26, 2022 •
edited

Dummy uses overlay dimming while the mirrored screen uses colortable based dimming - the two effects should not be applied at the same time. Only the mirror target real screen(s) should be affected, unless they are all virtual screens (like DisplayLink or iPad).

(+ there could be an option to specify how dummy brightness control works in relation to PIP windows, streams and mirroring)
@waydabber waydabber added bug Something isn't working pre-release feedback Feedack for a pre-release version labels May 26, 2022
@waydabber waydabber changed the title When a dummy is mirrored to a real screen, brightness control affects both which is wrong. When a dummy is mirrored/streamed to a real screen, brightness control does not work in a consistent manner May 26, 2022
@waydabber waydabber changed the title When a dummy is mirrored/streamed to a real screen, brightness control does not work in a consistent manner Keyboard shortcuts should not affect dummy screens directly May 27, 2022
@waydabber
Copy link
Owner Author

What to do is:

  • Keyboard control should not affect dummy screens directly (direct overlay dimming is still possible via menu slider).
  • When the mouse (or focused window if this option is enabled) is on a dummy display, in case of mirroring and full screen streaming the target screen(s) should be dimmed when colortable based and/or hardware dimming is available.

@waydabber waydabber self-assigned this May 27, 2022
@waydabber waydabber added this to the v1.2.4 milestone May 27, 2022
@waydabber waydabber added in progress Implementing unreleased Not released yet in beta form labels May 27, 2022
@waydabber waydabber changed the title Keyboard shortcuts should not affect dummy screens directly Brightness keyboard shortcuts should not affect dummy screens directly May 27, 2022
@waydabber waydabber added done All tasks are completed and removed in progress Implementing labels May 27, 2022
@waydabber waydabber changed the title Brightness keyboard shortcuts should not affect dummy screens directly Brightness keyboard shortcuts should not affect dummy screens directly but only non-dummy mirror or stream target displays May 27, 2022
@waydabber waydabber added pre-release available Released as beta version and removed unreleased Not released yet in beta form labels Jun 2, 2022
@waydabber waydabber added released Released and removed pre-release available Released as beta version labels Jun 28, 2022
@waydabber waydabber added the PIP/Stream PIP or full screen streaming label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waydabber waydabber

Labels
bug Something isn't working done All tasks are completed PIP/Stream PIP or full screen streaming pre-release feedback Feedack for a pre-release version released Released
Projects
None yet
Milestone
v1.2.4
Development

No branches or pull requests
1 participant
@waydabber