Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the color of the screen #14

Closed
tangruilover opened this issue Oct 27, 2021 · 21 comments
Closed

About the color of the screen #14

tangruilover opened this issue Oct 27, 2021 · 21 comments
Assignees
Labels
bug Something isn't working done All tasks are completed

Comments

@tangruilover
Copy link

First of all, thank you very much for enabling me to open hidpi.However, I found a problem. After turning on hidpi, the display on the screen became gray. Trying to adjust the display and the description file could not be significantly alleviated.I don't know what happened, can you help me?My external monitor is DELL U2520DR.Thank you!

@waydabber waydabber self-assigned this Oct 27, 2021
@waydabber waydabber added the bug Something isn't working label Oct 27, 2021
@waydabber
Copy link
Owner

waydabber commented Oct 27, 2021

Hey @tangruilover - this seems to be a color profile issue. Could you please try changing the "Color Profile" setting in System Preferences/Displays to other profiles and see if it helps?

Screen Shot 2021-10-27 at 9 22 38

I'd also like to give you a test version (as soon as I get there) to see if it helps.


Technical details: probably I should specify the following data explicitly while creating the dummy:

@property(nonatomic) struct CGPoint whitePoint; // @synthesize whitePoint=_whitePoint;
@property(nonatomic) struct CGPoint bluePrimary; // @synthesize bluePrimary=_bluePrimary;
@property(nonatomic) struct CGPoint greenPrimary; // @synthesize greenPrimary=_greenPrimary;
@property(nonatomic) struct CGPoint redPrimary; // @synthesize redPrimary=_redPrimary;

@tangruilover
Copy link
Author

After using the new app, the color of the screen is much better.Thank you very much!

@waydabber
Copy link
Owner

I am glad it works, thanks for the feedback!

This issue should be rectified by this: 243931b

I'll close this issue now (but will reopen if the issue resurfaces).

@waydabber waydabber added the done All tasks are completed label Oct 27, 2021
@tangruilover
Copy link
Author

I am glad it works, thanks for the feedback!

This issue should be rectified by this: 243931b

I'll close this issue now (but will reopen if the issue resurfaces).

Hi, can I download the app after adding RGB?

@waydabber
Copy link
Owner

Hmm. I thought the issue was resolved for you. The added colorsync information is going to be in the upcoming version. Here is an interim version meanwhile with this change:

https://www.dropbox.com/s/z9fu4677dbscb44/BetterDummy.zip?dl=1

Let me know whether it works or still you have the monochrome issue (if you have, you can still try changing Color Profile both under the dummy and the physical display - if these don't work, then I don't have other ideas what could be the problem). Thanks!

@tangruilover
Copy link
Author

Excuse me, I can't open the link.

@waydabber
Copy link
Owner

It should just simply just initiate a direct download, nothing else shows up (check your download folders, maybe it happened quickly). It's a dropbox thing.

@tangruilover
Copy link
Author

Excuse me,I am in China.

@waydabber
Copy link
Owner

waydabber commented Oct 27, 2021

Ahh, I understand, it is blocked then. :( I see. I added a new release for you, hope this helps.

https://github.com/waydabber/BetterDummy/releases/tag/v1.0.3

update: sorry the binary was corrupted, uploaded it again...

@tangruilover
Copy link
Author

It's awesome! The display effect is very good!

@tangruilover
Copy link
Author

I have shared your APP, I hope more people can see your method, I hope you don't mind.

@waydabber
Copy link
Owner

Of course, I am happy it works, thanks for the feedback! :)

@tangruilover
Copy link
Author

I found another problem.After the system enters the dormant state,When I enter the system again, I will find that the color display becomes YPbPr, not RGB.Can this problem be solved?

@tangruilover
Copy link
Author

The situation mentioned above appears, it may be that I turned on hdr on the monitor。Turn on hdr, it can make the color of the display reach 10bit。

@waydabber
Copy link
Owner

Well macOS on M1 likes to switch RGB and YPbPr around for some reason. Best solution in general is to specify explicitly the proper link settings as described here:

https://forums.macrumors.com/threads/mbp-m1-and-lg-27uk850-w-washed-out-colors.2270452/post-30262233

But your problem might be a different one.

Btw, I say that it makes no sense to turn on HDR at all on a VESA HDR 400 certified display as it is not really capable to display HDR content properly (these displays can process the signal but the panel and lighting system are simply not capable enough) - on macOS it only makes the desktop dim as the output range will be capped for normal desktop content. You are much better off using SDR and a video player (like IINA) that can use tone-mapping to replay HDR videos on SDR displays properly.

@tangruilover
Copy link
Author

Yes,my problem is different.I set HDR on the monitor.But it is not set in the system preferences.So,the panel and lighting system are simply capable enough.
Now, I use the newly released app and it solves my problem.
Thank you very much!

@tangruilover
Copy link
Author

Excuse me,I found another problem.After I set up mirroring on the external monitor, the message notification will not pop up.I guess it may be that the information notification pop-up window is on the virtual display.Is it a problem with my settings?

@waydabber
Copy link
Owner

Well, if you do mirroring then the notification should pop up on the screen. I did not notice this behavior but I'll try to look out for it and see if messages do pop up correctly. If they don't then there isn't much to do about it, it might be a macOS bug.

@MasterJH5574
Copy link

Excuse me,I found another problem.After I set up mirroring on the external monitor, the message notification will not pop up.I guess it may be that the information notification pop-up window is on the virtual display.Is it a problem with my settings?

@waydabber @tangruilover Hi folks! I also encounter the same issue.

To be more specific, when I connect my MBP to external display, I always close its lid. And in this case, banner notifications can pop up as usual when BetterDummy is turned off and the MBP is only connected to the 2K external display. However, the notifications won't pop up when BetterDummy is turned on.

FYI, my MBP is the latest MacBook Pro 16'' with M1 Pro chip. And the screenshots below are the configuration of the dummy display and the real external display. The resolution of both the dummy display and the Dell 2K display is set to 1920 x 1080 for my personal convenience.

Screen Shot 2021-10-31 at 11 11 18 PM

Screen Shot 2021-10-31 at 11 11 32 PM

I wonder whether this issue is caused by some Apple's bug. @waydabber Do you mind taking a look? Thanks a lot ❤️.

@waydabber
Copy link
Owner

Ok, I made a Q&A item about this so others might benefit. Here is the solution I think, let me know if it works! Thanks!

#40 (comment)

@MrUltimate
Copy link

Hi @waydabber, sorry to bring this issue back once again. I'm on an M1 Max MBP and facing intense washed out colors when enabling HDR. I just got a new Alienware AW3225QF QD-OLED monitor and it has been a hassle to get this monitor working with this 4k monitor.

Luckily BetterDisplay solves most of the issues but this HDR issue. The washed out image is quite intense. I have a similar bug on my work MBP (2019 Intel based Mac) but the issue isn't has intense and usually can be fixed by a restart. On my M1 Mac, however, this doesn't seem to be the case. Someone on MacRumors pointed out that if you turn off/on the monitor if fixes the issues, however the colors are still washed out, albeit not as intense as before. The issue persistent on every restart and every wake from sleep.

I'm on the latest release; 2.2.0. Please let me know if I can offer any other info. I would really love to get this issue resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done All tasks are completed
Projects
None yet
Development

No branches or pull requests

4 participants