Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iptables as Debian dependency #1062

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Conversation

DavidHenryThoreau
Copy link

No description provided.

@TriMoon
Copy link

TriMoon commented Aug 24, 2023

#903 (comment)

Wow, iptables has been deprecated from official Debian releases for 4 years, and Waydroid is still experiencing this issue until now.

So instead of this PR, a better solution would be to eliminate the iptables usage in the first place...
Unless it's acceptable to have a follow-up PR that undoes this PR also while trying to get rid of iptables in the future..

@Quackdoc
Copy link
Contributor

So instead of this PR, a better solution would be to eliminate the iptables usage in the first place...
Unless it's acceptable to have a follow-up PR that undoes this PR also while trying to get rid of iptables in the future..

iptables isn't a requirement, it's a recommendation and the sane default config. distros don't want to ship iptables can ship nftables instead via a simple patch in waydroid-net.sh. nftables has caused issues in the past.

as for this PR itself, I can't comment on how debian folks handle things, but IMO this should be listed as optional

-LXC_USE_NFT="false"
+LXC_USE_NFT="true"

@aleasto
Copy link
Member

aleasto commented Sep 7, 2023

Ideally we would just figure out how to coexist with docker when using nftables and enable it by default.

Other distributions are already shipping waydroid with ntables, although the status quo in Fedora for example is to use podman, so it's less of an issue

@aleasto
Copy link
Member

aleasto commented Sep 29, 2023

Wow, iptables has been deprecated from official Debian releases for 4 years, and Waydroid is still experiencing this issue until now.

FYI, iptables on modern systems is an alias for iptables-nft which is an iptables-compatible frontend for nft.

@aleasto aleasto merged commit d0ca6a3 into waydroid:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants