Add an option to decide whether to create a desktop file #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to add docs for this... somewhere |
|
We must create the desktop files otherwise the windows won't have an icon and will display the Wayland icon instead |
|
How does wine handle this on Wayland? Speaking of, i'd like this config to be called menu_builder as well, i think it makes sense. If we can land it... |
|
You're right, I didn't consider the specifics around Wine, this option may not be entirely robust yet. |
|
Instead of not creating them, perhaps it would be better to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new options
show_waydroid_appsinwaydroid.cfgto decide whether to create a dot desktop file for all apps.