Optimize indexPath search using visible cells #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
=========================================
Coverage ? 93.48%
=========================================
Files ? 39
Lines ? 3207
Branches ? 0
=========================================
Hits ? 2998
Misses ? 209
Partials ? 0
Continue to review full report at Codecov.
|
jay18001
suggested changes
Jul 17, 2017
| return false | ||
| } | ||
| } | ||
| return cells.map({ (cell) -> IndexPath in |
There was a problem hiding this comment.
Could we do a flatMap here that would removed the need for the force unwrap too
Searching for indexPaths could cause a lot of calculations. To find indexPaths for a given index, BrickKit will now first check the visible cells. If it can’t find it, it will continue to use the old, slower way Fixes #152
rubencagnie
force-pushed
the
152-optimize-indexpath-search
branch
from
6756a27
to
b461b41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searching for indexPaths could cause a lot of calculations. To find indexPaths for a given index, BrickKit will now first check the visible cells. If it can’t find it, it will continue to use the old, slower way
Fixes #152