Properly insert/delete items #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay18001
suggested changes
Jul 17, 2017
| @@ -346,8 +316,8 @@ extension BrickFlowLayout { | |||
| } | |||
|
|
|||
| var attributes: [UICollectionViewLayoutAttributes] = [] | |||
| for (_, section) in sections { | |||
| attributes += section.layoutAttributesForElementsInRect(rect, with: zIndexer) | |||
| for (sectionIndex, section) in sections { | |||
There was a problem hiding this comment.
can we use sections.forEach { ...
There was a problem hiding this comment.
Logic has a reference to to self (_collectionView & zIndexer)
Source/Layout/BrickFlowLayout.swift
Outdated
| isUpdating = true | ||
| if (insertedIndexPaths.count + deletedIndexPaths.count) > 0 { | ||
| zIndexer.reset(for: self) | ||
| for (sectionIndex, section) in sections! { |
There was a problem hiding this comment.
Can we change force unwrap to an if let
There was a problem hiding this comment.
It's OK to force unwrap sections. Without them being initialized, there wouldn't be any insert/delete possible
I've added a comment to describe this
Source/Cells/BrickCell.swift
Outdated
| @@ -206,8 +206,17 @@ open class BrickCell: BaseBrickCell { | |||
|
|
|||
| let preferred = layoutAttributes.copy() as! UICollectionViewLayoutAttributes | |||
|
|
|||
| let size = CGSize(width: layoutAttributes.frame.width, height: self.heightForBrickView(withWidth: layoutAttributes.frame.width)) | |||
| preferred.frame.size = size | |||
|
|
|||
The items that are inserted/deleted will now be properly placed in the correct atttributes location, so that the animations make much more sense Fixes #158
rubencagnie
force-pushed
the
158-insert-delete-fix
branch
from
7bb3d6d
to
06d8448
Compare
jay18001
approved these changes
Jul 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The items that are inserted/deleted will now be properly placed in the correct atttributes location, so that the animations make much more sense
Fixes #158