Provide a way to override brick cell content after the updateContent #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wfsttam
commented
Jan 6, 2017
wfsttam
commented
- provides a means of showing placeholder content
rubencagnie
reviewed
Jan 6, 2017
| @@ -24,6 +24,16 @@ public protocol BrickCellTapDelegate: UIGestureRecognizerDelegate { | |||
| func didTapBrickCell(brickCell: BrickCell) | |||
| } | |||
|
|
|||
| public protocol OverrideContentSource: class { | |||
| func overrideContent(forBrickCell brickCell: BrickCell) | |||
There was a problem hiding this comment.
What about the resetCell function to clean up the placeholder views?
rubencagnie
reviewed
Jan 6, 2017
| @@ -24,6 +24,16 @@ public protocol BrickCellTapDelegate: UIGestureRecognizerDelegate { | |||
| func didTapBrickCell(brickCell: BrickCell) | |||
| } | |||
|
|
|||
| public protocol OverrideContentSource: class { | |||
| func overrideContent(forBrickCell brickCell: BrickCell) | |||
There was a problem hiding this comment.
Let's do it "swift 3"-style
func overrideContent(for cell: BrickCell)
wfsttam
force-pushed
the
placeholder-content
branch
from
f8966a0
to
7c71342
Compare
wfsttam
changed the title
wfsttam
force-pushed
the
placeholder-content
branch
from
7c71342
to
a572e99
Compare
…k cell
- provides a way to show content while content is not available yet
- added tests
- example included in 'DynamicContentViewController'
wfsttam
force-pushed
the
placeholder-content
branch
from
a572e99
to
74c7ec8
Compare
rubencagnie
reviewed
Jan 6, 2017
| } | ||
|
|
||
| extension OverrideContentSource { | ||
| public func overrideContent(for brickCell: BrickCell) { |
Current coverage is 93.65% (diff: 100%)
|
wfsttam
changed the title
wfsttam
changed the title
|
Adds ability to insert temporary content or override content into a brick cell after updateContent is called: Fixes #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.