Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating workflow instance after on_message #46

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Conversation

patkivikram
Copy link
Collaborator

Description

Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to related issues, other PRs, or technical references.

Note that by not including a description, you are asking reviewers to do extra work to understand the context of this change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #46 (90c0fcd) into main (1cfc3a0) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   86.65%   86.55%   -0.11%     
==========================================
  Files          12       12              
  Lines        1828     1829       +1     
  Branches      214      214              
==========================================
- Hits         1584     1583       -1     
- Misses        144      146       +2     
  Partials      100      100              
Impacted Files Coverage Δ
dagger/tasks/task.py 79.26% <100.00%> (-0.37%) ⬇️

@patkivikram patkivikram merged commit 2060887 into main Jun 6, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants