Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

efficient writes and update tests #48

Merged
merged 2 commits into from
Sep 5, 2023
Merged

efficient writes and update tests #48

merged 2 commits into from
Sep 5, 2023

Conversation

patkivikram
Copy link
Collaborator

@patkivikram patkivikram commented Sep 4, 2023

Description

This PR removes unnecessary writes to the workflow instance thereby reducing callbacks

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #48 (869e2e7) into main (275530d) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   86.55%   86.51%   -0.04%     
==========================================
  Files          12       12              
  Lines        1829     1824       -5     
  Branches      214      215       +1     
==========================================
- Hits         1583     1578       -5     
- Misses        145      146       +1     
+ Partials      101      100       -1     
Files Changed Coverage Δ
dagger/modeler/definition.py 85.65% <0.00%> (-0.78%) ⬇️
dagger/store/stores.py 90.25% <ø> (ø)
dagger/templates/template.py 97.65% <ø> (ø)
dagger/service/services.py 84.55% <100.00%> (ø)
dagger/tasks/task.py 79.37% <100.00%> (+0.11%) ⬆️

@patkivikram patkivikram merged commit 2e751b1 into main Sep 5, 2023
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant