DRAFT: Draft for ticket #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsole
commented
Nov 14, 2022
| @@ -36,7 +36,8 @@ import ( | |||
|
|
|||
| // Constants and vars | |||
| const version = "0.4.2" | |||
| const workersCannelSize = 1024 | |||
|
|
|||
| const workersCannelSize = 1 | |||
There was a problem hiding this comment.
if the workers dont pickup new work, we dont want to hide the fact that requests are piling up.
nielsole
commented
Nov 14, 2022
| @@ -625,6 +626,7 @@ func main() { | |||
| flag.DurationVar(&config.fireDuration, "fire-duration", time.Second*10, "Duration of the benchmark. Specify 0 to run forever until stopped") | |||
| flag.IntVar(&config.fireRate, "fire-rate", 0, "Desired rate in requests/sec. Default is 0 - unlimited") | |||
|
|
|||
| // TODO: Set dynamically based on config.sendTimeout * config.fireRate | |||
There was a problem hiding this comment.
Theoretically that should mean that requests never ever pile up
nielsole
commented
Nov 14, 2022
| @@ -49,7 +50,7 @@ var registry = prometheus.NewRegistry() | |||
| // var secondsDurationBuckets = []float64{0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5, 10} | |||
|
|
|||
| // Objectives for summary distributions | |||
| var summaryObjectives = map[float64]float64{0.5: 0.05, 0.9: 0.01, 0.95: 0.005, 0.99: 0.001} | |||
| var summaryObjectives = map[float64]float64{0.5: 0.05, 0.9: 0.01, 0.95: 0.005, 0.99: 0.001, 1.0: 0.0} | |||
There was a problem hiding this comment.
P100 is interesting because we want to know the worst spikes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist