GenericBrick

[rubencagnie]

Introduction of a GenericBrick, that allows to wrap any UIView in a Brick.

This will allow a straight forward syntax:

GenericBrick<UILabel>(GenericLabelBrickIdentifier, size: BrickSize(...)) { label, cell in
            label.text = "LABEL " + String(cell.index)
            cell.edgeInsets = UIEdgeInsets(top: 5, left: 10, bottom: 15, right: 20)
        }

Fixes #64

[codecov-io]

Current coverage is 93.78% (diff: 100%)

No coverage report found for master at d5028f2.

Powered by Codecov. Last update d5028f2...d1c0ec9

[klundberg]

Looks good, just 2 comments before we should merge it.

[klundberg]

Can a filename have [] in it? Additionally, how would you configure a nib to interact with this brick? we create the generic view manually with init(frame:) below, so there's no opportunity for a nib to be instantiated.

[rubencagnie]

The nibName is used to identify the brick when registering. So in this case, there won't be a nib loaded, it will use the cellClass (GenericBrickCell)

[klundberg]

these could be written using layout anchors a bit more concisely

[rubencagnie]

Are anchors also constraints?

[klundberg]

The layout anchor API creates a constraint and automatically attaches it to the right view in the hierarchy. (You just need to set the active property on it to true before you're done). I can provide an example later, or you can take a look at the nslayoutanchor type and what anchors uiview has.

…

-- Kevin Lundberg

On Jan 24, 2017, at 7:30 PM, Ruben Cagnie ***@***.***> wrote: @rubencagnie commented on this pull request. In Source/Bricks/Generic/GenericBrick.swift: > + + public override func updateContent() { + super.updateContent() + + clearContentViewAndConstraints() + + if let generic = self._brick as? ViewGenerator { + let genericContentView = generic.generateView(self.frame, in: self) + genericContentView.translatesAutoresizingMaskIntoConstraints = false + + self.contentView.addSubview(genericContentView) + + let topSpaceConstraint = NSLayoutConstraint(item: genericContentView, attribute: .Top, relatedBy: .Equal, toItem: self.contentView, attribute: .Top, multiplier: 1, constant: edgeInsets.top) + let bottomSpaceConstraint = NSLayoutConstraint(item: self.contentView, attribute: .Bottom, relatedBy: .Equal, toItem: genericContentView, attribute: .Bottom, multiplier: 1, constant: edgeInsets.bottom) + let leftSpaceConstraint = NSLayoutConstraint(item: genericContentView, attribute: .Left, relatedBy: .Equal, toItem: self.contentView, attribute: .Left, multiplier: 1, constant: edgeInsets.left) + let rightSpaceConstraint = NSLayoutConstraint(item: self.contentView, attribute: .Right, relatedBy: .Equal, toItem: genericContentView, attribute: .Right, multiplier: 1, constant: edgeInsets.right) Are anchors also constraints? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[rubencagnie]

Fixes #56