Feature/wd 2297/credit assessment #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Export sdk functions and types - Add remaining functions: cancelSigning, accept and decline
ourbjorn
reviewed
Jan 29, 2021
|
|
||
| const inquiry = fixture("ICreditAssessmentInquiry"); | ||
|
|
||
| try { |
There was a problem hiding this comment.
I think it would make more sense to validate the throw directly;
expect(() => await newCase(inquiry)).toThrow();
ourbjorn
reviewed
Jan 29, 2021
| it("Throws error", async () => { | ||
| const inquiry = fixture("ICreditAssessmentInquiry"); | ||
|
|
||
| let err: any; |
There was a problem hiding this comment.
We should be able to get rid of some code, by expecting a throw instead;
expect(async () => await newCase(inquiry)).toThrow();
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add credit assessment support
This PR is related to this JIRA task
Changes