Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case sensitivity #80

Closed
rnc opened this issue May 12, 2016 · 9 comments
Closed

Case sensitivity #80

rnc opened this issue May 12, 2016 · 9 comments

Comments

@rnc
Copy link
Contributor

rnc commented May 12, 2016

If I have a list with e.g. Current and current listing on Current should not return current

rnc added a commit to rnc/wunderline that referenced this issue May 12, 2016
@Thor77
Copy link
Collaborator

Thor77 commented Sep 23, 2016

Why do you think so?
I think most people expect a search to be case-insensitive and I'm for keeping it like that.
@wayneashleyberry what to you think?

@wayneashleyberry
Copy link
Owner

I far prefer case insensitivity, @rnc is there a specific reason you need an exact match?

@rnc
Copy link
Contributor Author

rnc commented Sep 26, 2016

@wayneashleyberry I understand people have differing opinions on this. I am simply used to case sensitivity. If I recall (its a while since I've tried it) I think part of the problem was I had added a list entitled "Current" via the app/web api but there was some inconsistencies when attempting to list/modify it via the CLI. I wonder if a configuration option would help here?

@Thor77
Copy link
Collaborator

Thor77 commented Sep 26, 2016

Can you elaborate on your specific problem?
I don't really see the problem, because when adding a task on a specific list via wunderline, the list-name is converted to lowercase and listing of tasks on a specific list is currently not supported.

@rnc
Copy link
Contributor Author

rnc commented Sep 26, 2016

@Thor77 @wayneashleyberry As having multiple lists differing only in case is such a edge-case I would suggest just closing this?

@wayneashleyberry
Copy link
Owner

I actually wouldn't mind implementing this in a similar manner as smartcase in vim.

When 'ignorecase' and 'smartcase' are both on, if a pattern contains an uppercase letter, it is case sensitive, otherwise, it is not. For example, /The would find only "The", while /the would find "the" or "The" etc. (http://vim.wikia.com/wiki/Searching)

So by default search's are case insensitive, unless the search term contains an uppercase character. How's that sound @rnc?

@rnc
Copy link
Contributor Author

rnc commented Sep 27, 2016

@wayneashleyberry +1

@rnc
Copy link
Contributor Author

rnc commented Oct 16, 2016

@Thor77 I wonder if similar should apply to the search facility. From what I can see currently it is also case insensitive but is also using a fuzzy matching algorithm which means searching for e.g. RCM will return
"Update RCM"
and
"Handle releasing in config and new document"

The latter is a bit unintuitive. Either an explicit regexp of ability to quote would be useful. (Perhaps this is better as a separate issue?)

rnc added a commit to rnc/wunderline that referenced this issue Oct 17, 2016
rnc added a commit to rnc/wunderline that referenced this issue Oct 17, 2016
@Thor77
Copy link
Collaborator

Thor77 commented Oct 17, 2016

Yeah, please open an seperate issue for the search-command. We should extract this functionality into an own function then to provide a consistent experience throughout the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants