Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rvm-prompt s behavior change #1042

Closed
ches opened this issue Jul 10, 2012 · 2 comments
Closed

rvm-prompt s behavior change #1042

ches opened this issue Jul 10, 2012 · 2 comments
Assignees
Milestone

Comments

@ches
Copy link

ches commented Jul 10, 2012

86437e9 changed the behavior of rvm-prompt s when a non-system Ruby is active.

Technically the current documentation appears valid, but it's ambiguous:

By default rvm-prompt outputs the fully qualified ruby string necessary to select the particular ruby currently selected and nothing when system ruby is selected.

This part still holds, but for

(s)ystem - echo "system" when using system ruby

the behavior when not using system Ruby is undefined. It used to echo nothing, and it now outputs the default of rvm-prompt i v p g:

Before 86437e9

[ches@lupin]$ rvm current
system

[ches@lupin]$ rvm-prompt s
system

[ches@lupin]$ rvm-prompt

[ches@lupin]$ rvm default

[ches@lupin]$ rvm-prompt
ruby-1.9.2-p290

[ches@lupin]$ rvm-prompt s

After 86437e9

[ches@lupin]$ rvm current
system

[ches@lupin]$ rvm-prompt s
system

[ches@lupin]$ rvm-prompt

[ches@lupin]$ rvm default

[ches@lupin]$ rvm-prompt
ruby-1.9.2-p290

[ches@lupin]$ rvm-prompt s
ruby-1.9.2-p290

So I don't know if this is a bug per se, since docs are technically correct, but it broke my personal prompt customization, so I thought I'd bring it up. It does seem to me that, for a command that essentially asks the question "Am I using system Ruby?", a null-like response is a better negative answer than "ruby-1.9.2-p290" 😄

@mpapis
Copy link
Member

mpapis commented Jul 11, 2012

this seams as part of a bigger issue, currently using default might overwrite system ruby / is a final fallback, so this behavior is correct as the default ruby is available even in system mode

@ghost ghost assigned mpapis Jul 28, 2012
@mpapis mpapis closed this as completed in 280f8fc Sep 12, 2012
@mpapis
Copy link
Member

mpapis commented Sep 12, 2012

rvm-prompt s --no-default has the old behavior

mpapis added a commit that referenced this issue Sep 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants