Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and extend installing binaries for Rubinius #2373

Closed
brixen opened this issue Nov 21, 2013 · 21 comments
Closed

Fix and extend installing binaries for Rubinius #2373

brixen opened this issue Nov 21, 2013 · 21 comments
Milestone
rvm 1.24

Comments

@brixen
Copy link

brixen commented Nov 21, 2013

1. Fix installing binaries

RVM presently appears to match a Travis specification like rvm: rbx-2.2 to the highest matching available binary (eg rubinius-2.2.1.tar.bz2) as seen here: https://travis-ci.org/rubinius/travis-canary/jobs/14282001

However, the install failed with some issue about a gemset.

2. Extend installing binaries

The binary matching logic should first match a specific available binary. In the case above, a binary exists for rubinius-2.2.tar.bz2 and that is listed in the index.txt file. RVM should prefer that to the match that it performed. If the binary had not existed, it should have matched the highest available.

If a specific special case is needed, rvm: rbx should match rubinius.tar.bz2. In other words, the most specific match should accept no version numbers at all.
@joshk
Copy link

joshk commented Nov 21, 2013

👍

What about the case of rbx-2 ? This fails right now with a cryptic error: Unknown ruby interpreter string component: '2'.

@brixen
Copy link
Author

brixen commented Nov 21, 2013

It should match the highest available rubinius-2.x.y, unless there is a specific rubinius-2.tar.bz2.

@joshk
Copy link

joshk commented Nov 21, 2013

👍

@joshk
Copy link

joshk commented Nov 21, 2013

I am happy to update the Ruby VMs once these changes are ready :)

@brixen
Copy link
Author

brixen commented Nov 21, 2013

@joshk ❤️

mpapis added a commit that referenced this issue Nov 21, 2013
@mpapis
improved fuzzy matching of installed rubies, update #2373
96e3644
mpapis added a commit that referenced this issue Nov 21, 2013
@mpapis
add fuzzy matching for remote rubies, update #2373
e8655d0
@mpapis mpapis closed this as completed in 1f22e06 Nov 21, 2013
@mpapis
Copy link
Member

mpapis commented Nov 21, 2013

@joshk any chance you could test rvm get head with the new rubinius names like rbx-2 or rbx-2.1?

@brixen brixen mentioned this issue Nov 21, 2013
Closed
mpapis added a commit that referenced this issue Nov 21, 2013
@mpapis
prevent use matching directories, update #2373
472f8f3
mpapis added a commit that referenced this issue Nov 21, 2013
@mpapis
prevent use matching gemsets, update #2373
b5798d7
@brixen
Copy link
Author

brixen commented Nov 21, 2013

The output on the builds for the travis-canary project seem different, so in case this change to RVM was deployed, there are more bugs: https://travis-ci.org/rubinius/travis-canary/builds/14337331

  1. rbx-2.2.1 the build just hung https://travis-ci.org/rubinius/travis-canary/jobs/14337332
  2. rbx-2.2 installed 2.2.1 correctly but died trying to do gemset things https://travis-ci.org/rubinius/travis-canary/jobs/14337333
  3. rbx-2 unknown Ruby interpreter thing https://travis-ci.org/rubinius/travis-canary/jobs/14337334
  4. rbx installed 2.2.0, which is not the newest (it's 2.2.1) https://travis-ci.org/rubinius/travis-canary/jobs/14337335

@mpapis
Copy link
Member

mpapis commented Nov 21, 2013

the error from 3. is from old version - so the new code was not deployed yet

@brixen
Copy link
Author

brixen commented Nov 21, 2013

Ah the difference with rbx appears to be the removal of the rewriting code.

@joshk
Copy link

joshk commented Nov 21, 2013

I can try updating rvm in a debug vm and test out these combos if you like?

On 22 November 2013 at 12:24:45 am, Michal Papis (notifications@github.com) wrote:

the error from 3. is from old version - so the new code was not deployed yet

—
Reply to this email directly or view it on GitHub.

@mpapis
Copy link
Member

mpapis commented Nov 21, 2013

@joshk please try updating to rvm get head I did not release stable with the changes yet

@joshk
Copy link

joshk commented Nov 21, 2013

Seems to work a charm, can we get this into 1.24.x?

@mpapis
Copy link
Member

mpapis commented Nov 21, 2013

working on extra fix for detecting more short versions, will push stable in hour or two

@joshk
Copy link

joshk commented Nov 21, 2013

awesome, I will build a new image tomorrow and update production :)

@joshk
Copy link

joshk commented Nov 21, 2013

Ahhh, found a bug...

travis@debug-josh-rvm-ruby-1385076787:~$ rvm use rbx --install --binary --fuzzy
rbx-2.2.1 is not installed.
Searching for binary rubies, this might take some time.
Found remote file http://binaries.rubini.us/ubuntu/12.04/x86_64/rubinius-2.2.1.tar.bz2
Checking requirements for ubuntu.
Requirements installation successful.
rbx-2.2.1 - #configure
rbx-2.2.1 - #download
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 18.7M  100 18.7M    0     0  3868k      0  0:00:04  0:00:04 --:--:-- 3931k
No checksum for downloaded archive, recording checksum in user configuration.
rbx-2.2.1 - #validate archive
rbx-2.2.1 - #extract
rbx-2.2.1 - #validate binary
rbx-2.2.1 - #setup
Using /home/travis/.rvm/gems/rbx-2.2.1
Saving wrappers to '/home/travis/.rvm/wrappers/rbx-2.2.1'......
rbx-2.2.1 - #importing default gemsets, this may take time...................
Using /home/travis/.rvm/gems/rbx-2.2.1
travis@debug-josh-rvm-ruby-1385076787:~$ rvm use rbx-2 --install --binary --fuzzy
Using /home/travis/.rvm/gems/rbx-2.2.1
travis@debug-josh-rvm-ruby-1385076787:~$ rvm use rbx-2.2 --install --binary --fuzzy
Using /home/travis/.rvm/gems/rbx-2.2.1
travis@debug-josh-rvm-ruby-1385076787:~$ rvm use rbx-2.2.0 --install --binary --fuzzy
rbx-2.2.0 is not installed.
Searching for binary rubies, this might take some time.
Found remote file http://binaries.rubini.us/ubuntu/12.04/x86_64/rubinius-2.2.0.tar.bz2
Checking requirements for ubuntu.
Requirements installation successful.
rbx-2.2.0 - #configure
rbx-2.2.0 - #download
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 17.6M  100 17.6M    0     0  1865k      0  0:00:09  0:00:09 --:--:-- 1812k
No checksum for downloaded archive, recording checksum in user configuration.
rbx-2.2.0 - #validate archive
rbx-2.2.0 - #extract
rbx-2.2.0 - #validate binary
rbx-2.2.0 - #setup
Using /home/travis/.rvm/gems/rbx-2.2.0
Saving wrappers to '/home/travis/.rvm/wrappers/rbx-2.2.0'......
rbx-2.2.0 - #importing default gemsets, this may take time...................
Using /home/travis/.rvm/gems/rbx-2.2.0
travis@debug-josh-rvm-ruby-1385076787:~$ rvm use rbx-2.2 --install --binary --fuzzy
Using /home/travis/.rvm/gems/rbx-2.2.1
travis@debug-josh-rvm-ruby-1385076787:~$ rvm use rbx-2.2.0 --install --binary --fuzzy
Using /home/travis/.rvm/gems/rbx-2.2.0
travis@debug-josh-rvm-ruby-1385076787:~$ rvm use rbx-2.2.1 --install --binary --fuzzy
Using /home/travis/.rvm/gems/rbx-2.2.1
travis@debug-josh-rvm-ruby-1385076787:~$ rvm -v

rvm 1.24.1 (master) by Wayne E. Seguin <wayneeseguin@gmail.com>, Michal Papis <mpapis@gmail.com> [https://rvm.io/]

travis@debug-josh-rvm-ruby-1385076787:~$ rvm use rbx
Using /home/travis/.rvm/gems/rbx-2.2.0

The last rvm use rbx is using 2.2.0 instead of 2.2.1

@mpapis
Copy link
Member

mpapis commented Nov 21, 2013

it's not a bug, it is recorded version of rubinius in rvm - it is 2.2.0, you need to use fuzzy to find latest version of the installed rubies:

rvm use rbx --install --binary --fuzzy

@joshk
Copy link

joshk commented Nov 22, 2013

But I did a rvm get head? Is that not supposed to update the recorded version?

@joshk
Copy link

joshk commented Nov 22, 2013

You have to admit that

travis@debug-josh-rvm-ruby-1385076787:~$ rvm use rbx
Using /home/travis/.rvm/gems/rbx-2.2.0
travis@debug-josh-rvm-ruby-1385076787:~$ rvm use rbx --fuzzy
Using /home/travis/.rvm/gems/rbx-2.2.1

is a little odd

@mpapis
Copy link
Member

mpapis commented Nov 22, 2013

yep I did not update the recorded version for rubinius yet, the new fuzzy will check the available binaries for you always so it will work just fine

@joshk
Copy link

joshk commented Nov 22, 2013

Ok, great, let me know when I should run the tests once more :)

mpapis added a commit that referenced this issue Nov 22, 2013
@mpapis
improved fuzzy matching of ruby versions when only part name given, u…
de3debc 
…pdate rubinius to 2.2.1, update #2373
mpapis added a commit that referenced this issue Nov 22, 2013
@mpapis
fix issue in handling extra version matching when no interpreter foun…
f724cb9 
…d, update #2373
mpapis added a commit that referenced this issue Nov 22, 2013
@mpapis
handle extra case when interpreter was not detected. update #2373
d88abba
@mpapis
Copy link
Member

mpapis commented Nov 22, 2013

released 1.24.2

@tmilewski tmilewski mentioned this issue Dec 3, 2013
Closed
@robertomiranda robertomiranda mentioned this issue Dec 11, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
rvm 1.24
Development

No branches or pull requests
3 participants
@brixen @joshk @mpapis