Fixed a few typos in upgrade-notes.txt #2238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you please move the changed points to the end - we use diff and display the incoming changes to the user - without moving to the end only the changed lines would appear without proper context or ending. |
|
Oh, I see. Okay, reordered. 😃 |
|
https://travis-ci.org/wayneeseguin/rvm/builds/12032683#L249 - still not good, can you move the initially changed lines to the end of the file? |
|
I had to play a bit to make it display properly in the diff, hopefully it will not conflict with older version, we need to find better format for newer versions so the notes can be improved without creating conflicts, possibly separate files - but then it's work for RVM 2. |
|
OK cool! Sorry, that ended up being a lot of trouble for a couple lousy typos. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple quick things I noticed when I upgraded :)