Base record hash setter inconsistent behaviour +temporary fix

[KieranP]

Xeroizer 0.3.5

https://github.com/waynerobinson/xeroizer/blob/master/lib/xeroizer/record/base.rb#L53

invoice[:date] = Date.today
=> nil

The problem it seems, when compared to the working build method, is that []= is forgetting to convert the attribute setter string to a symbol.

If we change the line

self.send("#{attribute}=", value)

to

self.send("#{attribute}=".to_sym, value)

it appears to fix the issue:

invoice[:date] = Date.today 
=> Mon, 05 Sep 2011

I've had reports that it'll work sometimes, and not others. We're not sure of the exact cause at this stage.

Could be caused because of a loop we use:

new_attrs.each { |k,v| invoice[k] = v }

(side-note: a merge method would be great)

[waynerobinson]

Hi Kieran

That seems reasonable to me. Do you mind submitting as a pull request?

Also, happy to look at a pull request with a merge implementation.

Cheers

Wayne

On 5 September 2011 13:51, KieranP <
reply@reply.github.com>wrote:

Xeroizer 0.3.5

https://github.com/waynerobinson/xeroizer/blob/master/lib/xeroizer/record/base.rb#L53

invoice[:date] = Date.today
=> nil

The problem it seems, when compared to the working build method, is that
[]= is forgetting to convert the attribute setter string to a symbol.

If we change the line

self.send("#{attribute}=", value)

to

self.send("#{attribute}=".to_sym, value)

it appears to fix the issue:

invoice[:date] = Date.today
=> Mon, 05 Sep 2011

I've had reports that it'll work sometimes, and not others. We're not sure
of the exact cause at this stage.

Could be caused because of a loop we use:

new_attrs.each { |k,v| invoice[k] = v }

(side-note: a merge method would be great)

Reply to this email directly or view it on GitHub:
#25

[waynerobinson]

This has now been resolved.