Rails 5: Calling to_s on a BigDecimal results in an infinite loop

[benpritchard]

xeroizer/lib/big_decimal_to_s.rb

Line 3 in 960e78c

def to_s_with_default_format(format = 'F')

class BigDecimal

  def to_s_with_default_format(format = 'F')
    to_s_without_default_format(format)
  end
  alias_method :to_s_without_default_format, :to_s
  alias_method :to_s, :to_s_with_default_format

end

With rails 5.0.0.beta2, calling to_s on a BigDecimal and xeroizer installed results in an infinite loop.

Sample backtrace:

     # /Users/ben/.rvm/gems/ruby-2.2.4/gems/activesupport-5.0.0.beta2/lib/active_support/core_ext/big_decimal/conversions.rb:9:in `to_s'
     # /Users/ben/.rvm/gems/ruby-2.2.4/gems/xeroizer-2.16.1/lib/big_decimal_to_s.rb:4:in `to_s_with_default_format'
     # /Users/ben/.rvm/gems/ruby-2.2.4/gems/activesupport-5.0.0.beta2/lib/active_support/core_ext/big_decimal/conversions.rb:9:in `to_s'
     # /Users/ben/.rvm/gems/ruby-2.2.4/gems/xeroizer-2.16.1/lib/big_decimal_to_s.rb:4:in `to_s_with_default_format'
     # /Users/ben/.rvm/gems/ruby-2.2.4/gems/activesupport-5.0.0.beta2/lib/active_support/core_ext/big_decimal/conversions.rb:9:in `to_s'
     # /Users/ben/.rvm/gems/ruby-2.2.4/gems/xeroizer-2.16.1/lib/big_decimal_to_s.rb:4:in `to_s_with_default_format'
     # /Users/ben/.rvm/gems/ruby-2.2.4/gems/activesupport-5.0.0.beta2/lib/active_support/core_ext/big_decimal/conversions.rb:9:in `to_s'
     # /Users/ben/.rvm/gems/ruby-2.2.4/gems/xeroizer-2.16.1/lib/big_decimal_to_s.rb:4:in `to_s_with_default_format'
     # /Users/ben/.rvm/gems/ruby-2.2.4/gems/activesupport-5.0.0.beta2/lib/active_support/core_ext/big_decimal/conversions.rb:9:in `to_s'
     # /Users/ben/.rvm/gems/ruby-2.2.4/gems/xeroizer-2.16.1/lib/big_decimal_to_s.rb:4:in `to_s_with_default_format'
     # /Users/ben/.rvm/gems/ruby-2.2.4/gems/activesupport-5.0.0.beta2/lib/active_support/core_ext/big_decimal/conversions.rb:9:in `to_s'

     # /Users/ben/.rvm/gems/ruby-2.2.4/gems/xeroizer-2.16.1/lib/big_decimal_to_s.rb:4:in `to_s_with_default_format'
     # /Users/ben/.rvm/gems/ruby-2.2.4/gems/activesupport-5.0.0.beta2/lib/active_support/core_ext/big_decimal/conversions.rb:9:in `to_s'
     # /Users/ben/.rvm/gems/ruby-2.2.4/gems/activesupport-5.0.0.beta2/lib/active_support/core_ext/numeric/conversions.rb:126:in `to_s'

This seems to be the commit that changed things: rails/rails@f61dd4f

[Schwad]

Got this same issue, thanks for the fix.

[bendangelo]

Thanks for the fix.

[Rio517]

Now if we could just get the version bummed up so folks aren't running around trying to figure out why their upgraded app is so freaking slow. Thanks!

[SylarRuby]

Oh. Where're the fix? #317