Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add errors to the record if ApiException is raised #551

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add errors to the record if ApiException is raised #551

wants to merge 4 commits into from

Commits on Oct 19, 2021

  1. make it possible to run unit tests individually 

    fixes waynerobinson#549
    @timdiggins
    timdiggins committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    b703483 View commit details
    Browse the repository at this point in the history

  2. add errors to the record if ApiException is raised. 

    This does a very basic fix to waynerobinson#538 by parsing the thrown
ApiException.

This won't help if an ApiException isn't thrown (unexpected error).
It also feels rather ugly having to catch and re-raise, but any other
change would be a very significant refactor.
    @timdiggins
    timdiggins committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    f5908ba View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. drop unnecessary valid? from the implementation

    @timdiggins
    timdiggins committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    8a640bd View commit details
    Browse the repository at this point in the history

  2. don't reraise exception (convert ApiException to RecordInvalid)

    @timdiggins
    timdiggins committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    c568e55 View commit details
    Browse the repository at this point in the history