rename getImage() to be getSocialImage() since that's what it is look…

…ing for
waynestate · Oct 24, 2023 · e67339a · e67339a
1 parent b0504a4
commit e67339a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/app/Http/Controllers/ArticleController.php b/app/Http/Controllers/ArticleController.php
@@ -99,7 +99,7 @@ public function show(Request $request): View|Redirector|RedirectResponse
             $request->data['base']['hero'][]['relative_url'] = $article['article']['data']['hero_image']['url'];
         }
 
-        $image = $this->article->getImage($article['article']['data']);
+        $image = $this->article->getSocialImage($article['article']['data']);
 
         $request->data['base']['meta']['image'] = $image['url'];
         $request->data['base']['meta']['image_alt'] = $image['alt_text'];

diff --git a/app/Repositories/ArticleRepository.php b/app/Repositories/ArticleRepository.php
@@ -77,7 +77,7 @@ public function find($id, $application_ids, $preview = null)
     /**
      * {@inheritdoc}
      */
-    public function getImage($article)
+    public function getSocialImage($article)
     {
         if (!empty($article['social_image'])) {
             return [

diff --git a/contracts/Repositories/ArticleRepositoryContract.php b/contracts/Repositories/ArticleRepositoryContract.php
@@ -31,7 +31,7 @@ public function find($id, $application_ids, $preview);
      * @param array $article
      * @return array
      */
-    public function getImage($article);
+    public function getSocialImage($article);
 
     /**
      * Set the paging.

diff --git a/tests/Unit/Repositories/ArticleRepositoryTest.php b/tests/Unit/Repositories/ArticleRepositoryTest.php
@@ -148,7 +148,7 @@ public function article_with_no_images_should_return_null(): void
             'body' => null,
         ]);
 
-        $imageUrl = app(ArticleRepository::class)->getImage($article);
+        $imageUrl = app(ArticleRepository::class)->getSocialImage($article);
 
         $this->assertNull($imageUrl['url']);
         $this->assertNull($imageUrl['alt_text']);
@@ -161,7 +161,7 @@ public function article_with_hero_should_return_hero_url(): void
             'social_image' => null,
         ]);
 
-        $imageUrl = app(ArticleRepository::class)->getImage($article['data']);
+        $imageUrl = app(ArticleRepository::class)->getSocialImage($article['data']);
 
         $this->assertEquals($article['data']['hero_image']['url'], $imageUrl['url']);
         $this->assertEquals($article['data']['hero_image']['alt_text'], $imageUrl['alt_text']);
@@ -179,7 +179,7 @@ public function article_with_body_image_should_return_url(): void
             'body' => '<img src="'.$url.'" alt="'.$alt.'">',
         ]);
 
-        $image = app(ArticleRepository::class)->getImage($article['data']);
+        $image = app(ArticleRepository::class)->getSocialImage($article['data']);
 
         $this->assertEquals($url, $image['url']);
         $this->assertEquals($alt, $image['alt_text']);
@@ -190,7 +190,7 @@ public function article_with_social_image_should_return_url(): void
     {
         $article = app(Article::class)->create(1, true);
 
-        $imageUrl = app(ArticleRepository::class)->getImage($article['data']);
+        $imageUrl = app(ArticleRepository::class)->getSocialImage($article['data']);
 
         $this->assertEquals($article['data']['social_image']['url'], $imageUrl['url']);
         $this->assertEquals($article['data']['social_image']['alt_text'], $imageUrl['alt_text']);