Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/modular 2 #660

Closed
wants to merge 8 commits into from
Closed

Feature/modular 2 #660

wants to merge 8 commits into from

Conversation

breakdancingcat
Copy link
Member

@breakdancingcat breakdancingcat commented Oct 23, 2023 •
edited
Loading

  • Moved the events/articles to a modular component and removed them from the controller
  • Carried over "change promo item display" from promo page (removes excerpt, description from showing, appends a single promo view page link)
  • Fixed the spotlight component, and fixed stlying for video row, video column, image promo
  • Chris is adding a calendar url to the event api so that's what $dates[0]['calendar_url'] is for (Reducing the need for a separate page field for calendar url)
  • Rearranged styleguide page

@breakdancingcat breakdancingcat requested a review from a team as a code owner October 23, 2023 17:11
@breakdancingcat breakdancingcat temporarily deployed to build October 23, 2023 17:11 — with GitHub Actions Inactive
@breakdancingcat breakdancingcat temporarily deployed to build October 23, 2023 17:12 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 23, 2023 •
edited
Loading

Coverage Status

coverage: 98.627% (-1.4%) from 100.0% when pulling 9af0a23 on feature/modular-2 into 40ff1a0 on develop.

@breakdancingcat breakdancingcat temporarily deployed to build October 23, 2023 17:15 — with GitHub Actions Inactive
@breakdancingcat breakdancingcat temporarily deployed to build October 24, 2023 03:19 — with GitHub Actions Inactive
@breakdancingcat breakdancingcat deleted the feature/modular-2 branch October 24, 2023 03:26
nickdenardis
nickdenardis reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@nickdenardis nickdenardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickdenardis nickdenardis nickdenardis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@breakdancingcat @coveralls @nickdenardis