Refactoring components #687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
breakdancingcat
commented
Jan 17, 2024
•
breakdancingcat
commented
- Ensured each type of hero worked with the rotate class.
- Removed the xxxl breakpoint, it wasn't used but the tailwind file had a misconfiguration.
- Renamed "banner" to "flag" (Make a gift flag is how we refer to it anyway), and goign to call the hero area "banner", Tall banner, Short banner.
- Maxing the hero height at 550 like it used to be, to prevent the hero from continuing to consume so much height on wide screens.
- Fixing full-width template, previously breadcrumbs didn't have any padding, so the breadcrumbs component now has padding and the overall padding of 'content area' was removed.
- Adding full customization details within full-width template styleguide as a reference.
- Refactoring list-item and grid-item to work without images (content only promo).
- Restyled the blockquote component to have the gold left bar.
…t just using images
…mage content, renamed skinny hero to banner because that is a more known term, renamed banner gift flag to just flag, made progress on reworking full width template which included changing where the padding in the content area was, so the breadcrumbs component has padding on it now and looks great in all templates, removed contained hero in place of banner hero, adding the content promo back into the components until the wysiwyg page field is complete
…ing to work on the full-width example template
Moving modular template configuration to childpage and making components consistent and Optimizing components to mirror each other as much as possible and reduce duplicate information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.