Feature/refactor 2 #688
Feature/refactor 2 #688
Conversation
breakdancingcat
commented
Jan 22, 2024
•
breakdancingcat
commented
- Updating component descriptions from the content team, including what happens to under-menu buttons on mobile
- Modified the full-width template to set the groundwork for fully custom homepages
- Removed 'contained' hero in favor of the wull-width skinny/banner
- Using TW's "zinc" for grays; we were already using most that palette with a few exceptions, but this is basically an unnoticable change, removing a couple warmer grays that didn't fit
- Alt text when a video url is used is unavailable, using the title until we have a way to add it
- Added ability to move page content to placement of a page field
…ome up often but it does come up for larger sites.
…previously and its unecessary and unnoticable. Without including DEFAULT we would have to replace everywhere we have text-gray etc with text-gray-400, so i had to include it one number at a time
…ntil we have a better option for video alt text
…s two columns as a page field
| --}} | ||
|
|
||
| @foreach ($data as $heading) | ||
| <h2 class="mt-0 -mb-3">{{ $heading['title'] }}</h2> |
There was a problem hiding this comment.
Since this is not the page heading, but more of a section heading, what do you think about using the label "section-heading" or "section-header"?
There was a problem hiding this comment.
Should I make all modular headings section headings?
There was a problem hiding this comment.
No need to go overboard with using this partial, I was only commenting on the naming. Didn't want a sub-heading within a page to be confused by the primary page heading. (which should be the only H1 on the page)
There was a problem hiding this comment.
@nickdenardis this would be used to span two columns over a featured event image and an events list, so the heading would be "Events" which we've never labelled
| @@ -12,7 +12,7 @@ | |||
| @if(!empty($item['relative_url'])) | |||
| @image($item['relative_url'], $item['filename_alt_text'], "w-full lazy") | |||
| @else | |||
| @image('//i.wayne.edu/youtube/'.$item['youtube_id'].'/max', $item['filename_alt_text'], "w-full lazy") | |||
There was a problem hiding this comment.
Only as an FYI. We will shortly here have the ability to write alt text for a promotion item that doesn't have an image uploaded. TP3 #175511
| <li><strong>Examples:</strong> "Apply now," "Request information," "Speak with an advisor," etc. | ||
| <li><strong>Placement:</strong> CTAs are most effective on landing pages and frequently visited sections with important information. | ||
| </ul> | ||
| <h3 class="text-lg my-0">Under-menu button column</h3> |
There was a problem hiding this comment.
We may want to reference the automatic insertion of under-menu CTA buttons after the first paragraph that happens automatically on small screens:
https://github.com/waynestate/base-site/blob/master/resources/js/modules/under-menu.js
|
I will add coverages for what i introduced after I make sure it's how I want it to be formatted |
…ter first paragraph on mobile
…or promo data (page-content, page-heading components)
