Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/8.8.0 #692

Merged
merged 57 commits into from
Feb 2, 2024
Merged

Release/8.8.0 #692

merged 57 commits into from
Feb 2, 2024

Conversation

breakdancingcat
Copy link
Member

@breakdancingcat breakdancingcat commented Feb 1, 2024 •
edited

  • Only displaying a component if the view exists
  • Hero changes
    • Maxing the full-width now "banner large" hero height at 550px
    • Refactored hero, the options are now Banner small, Banner large, Text overlay, SVG overlay, Half, Logo
    • Adjusted the carousel JS to make sure it was getting the height appropriately
    • Logo hero now works in carousel - styleguide carousel hero options randomize on refresh
    • Replaced "Contained hero" with "Banner small" (Wayne.edu child hero size)
    • Removed base hero full configuration, no more contained hero
  • Added full list of available component custom page fields to the bottom of the "Using Components" page
  • Modified the full-width template, more accurately named "custom full width" since it's not readily available in the CMS
    • Provided groundwork for typical customizations we do for custom homepage templates
  • Added featured events row and column components that use images from the events calendar
  • Added featured news column that uses images from the news manager
  • Added modular-page-content that relocates the position of the CMS WYSIWYG body to the hierarchal placement of the page field
    • Noticed a case where a page content column was warranted - yourfuture next to a form
    • Updating all resources to include modular-page-content-row and modular-page-content-column
  • Added modular-heading to be able to add headings across two column components like a promo column and list of news column
  • Removed the xxxl breakpoint in favor of the 3xl breakpoint
  • Found and removed last instance of 'grey'
  • Made sure coverages remained 100%
  • Handling cross-site promotions in modularrepository when you are developing from base only (viewing writing center promos from base for layout creation)
  • Adding nested unordered and ordered list styles
  • Removing unused components
  • Adding heading id's for deep linking
  • Added blockquote style
  • Renamed the gift flag to flag instead of banner
  • Updated button-row component to allow one button centered

breakdancingcat and others added 30 commits January 11, 2024 12:09
@breakdancingcat
Making sure this works with rotate
de81000
@breakdancingcat
fixing inconsistency with breakpoints
9d47c24
@breakdancingcat
Fixing a screen inconsistency
6ba0832
@breakdancingcat
Getting rid of the last instance of 'grey'
a27901c
@breakdancingcat
Maxing the hero height at 550px oldschool
8b70608
@breakdancingcat
adaptive height gets the correct height of the carousel when we aren'…
7484a4e 
…t just using images
@breakdancingcat
Allowing logo overlay hero to work in a carousel
fcd8e46
@breakdancingcat
Tying up loose ends, the rotate carousel height had issues with non-i…
d1a7304 
…mage content, renamed skinny hero to banner because that is a more known term, renamed banner gift flag to just flag, made progress on reworking full width template which included changing where the padding in the content area was, so the breadcrumbs component has padding on it now and looks great in all templates, removed contained hero in place of banner hero, adding the content promo back into the components until the wysiwyg page field is complete
@breakdancingcat
Hero refactoring for customizations
6d4df03
@breakdancingcat
adding typical customizations to full-width template
cd9a8e8
@breakdancingcat
Finding minor style issues in components and addressing them, continu…
1e133af 
…ing to work on the full-width example template
@breakdancingcat
Merge tag '8.7.0' into develop
d5e50cb 
Moving modular template configuration to childpage and making components consistent and Optimizing components to mirror each other as much as possible and reduce duplicate information
@breakdancingcat
Merge branch 'develop' into feature/refactor
1bddf2d
@breakdancingcat
Was testing this, didn't mean to commit this editorconfig change
2ba81ee
@breakdancingcat
Not using a separate page to explain content component (promo component)
b184811
@breakdancingcat
Merge branch 'feature/refactor' into develop
6da6f42
@breakdancingcat
Using components page, removed typo for imageSize, clarified imagesize
2fec456
@breakdancingcat
Renamed full width content template to custom full-width
5221ef1
@breakdancingcat
Laying the ground work for site-specific customizations. It doesn't c…
08f6738 
…ome up often but it does come up for larger sites.
@breakdancingcat
Removing 'contained' hero and associated logic
5526d3c
@breakdancingcat
Using tailwinds zinc colors for grays, we had a mixture of tw colors …
d2d49e6 
…previously and its unecessary and unnoticable. Without including DEFAULT we would have to replace everywhere we have text-gray etc with text-gray-400, so i had to include it one number at a time
@breakdancingcat
filename alt text doesn't exist when using a video url, using title u…
3046cbb 
…ntil we have a better option for video alt text
@breakdancingcat
Moving page content with a page field, and adding a heading that span…
5b4dd57 
…s two columns as a page field
@breakdancingcat
Adding in new component descriptions
d5b093b
@breakdancingcat
Adding in new component descriptions
65fec78
@breakdancingcat
Removing contained hero
362d16c
@chrispelzer
Merge tag '8.7.1' into develop
9e7ae8c 
no message
@breakdancingcat
Added note to the buttonset page about under menu buttons inserted af…
4cd4201 
…ter first paragraph on mobile
@breakdancingcat
Refactored condition for w-full class
baaa655
@breakdancingcat
Refactored what to do when there's a json array but no news, events, …
8deaa9e 
…or promo data (page-content, page-heading components)
@breakdancingcat breakdancingcat requested a review from a team as a code owner February 1, 2024 05:36
@coveralls
Copy link

coveralls commented Feb 1, 2024 •
edited

Coverage Status

coverage: 100.0%. remained the same
when pulling 97cefbc on release/8.8.0
into acd4e50 on master.

nickdenardis
nickdenardis approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@nickdenardis nickdenardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@breakdancingcat breakdancingcat merged commit 5896dd9 into master Feb 2, 2024
2 checks passed
@chrispelzer chrispelzer deleted the release/8.8.0 branch February 5, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickdenardis nickdenardis nickdenardis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@breakdancingcat @coveralls @nickdenardis @chrispelzer