Feature/refactor 4 #693
Merged
Feature/refactor 4 #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-page-content-column
…otion images in the modular repository
nickdenardis
reviewed
Feb 2, 2024
| // Fake return | ||
| $return['promotions'] = app(GenericPromo::class)->create(5, false, [ | ||
| 'relative_url' => '/promo/image.jpg', | ||
| 'filename_url' => 'https://base.wayne.edu/promo/image.jpg', |
There was a problem hiding this comment.
Should these be real or faker image URLs?
There was a problem hiding this comment.
They will never be accessed, only for test purposes to make sure the relative url is replaced. I could change them, but I skipped going through the effort of faking it and making sure the fakes matched because they are only used for the test.
There was a problem hiding this comment.
Thanks for this explanation, this makes sense. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modular-page-contentthat relocates the position of the CMS WYSIWYG body to the hierarchal placement of the page fieldmodular-page-content-rowandmodular-page-content-column