New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility updates, header updated #4

Merged

nickdenardis merged 1 commit into master from hotfix/1.1.2

Oct 19, 2018

Member

nickdenardis commented Oct 19, 2018

Reason for change

There are a few accessibility errors that needed to be addressed and the Wayne State header branding needed to be updated.

Changes

Moved the graphic to a background since it is presentational content
Added skip links to get right to the content of the page
Added landmarks
Updated the WSU header to be the full header
Small view tweaks for readability

Checklist

~~Provide TP3 link:~~
~~Provide CMS site link:~~
Read through the code diff to ensure accuracy
SiteImprove accessibility check
Verified each page looks good on each viewport size
~~Added an example to the styleguide if applicable~~
~~Added tests to prove my code works~~
~~Refactored foreach loops into more maintainable collection chaining~~
Screen shot or video of before/after

Screenshots / Videos

Before	After

Before	After

Before	After

nickdenardis added the enhancement label

nickdenardis self-assigned this

nickdenardis requested a review from a team

October 19, 2018 15:47

robertvrabel approved these changes

View reviewed changes

robertvrabel approved these changes

View reviewed changes


          Accessibility updates, header updated

a1f7a1f

nickdenardis force-pushed the hotfix/1.1.2 branch from a2a1953 to a1f7a1f Compare

October 19, 2018 17:40

nickdenardis merged commit a1f7a1f into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment