Merge pull request #709 from wayofdev/feat/infra-dx

refactor: apply rector rules
wayofdev · Apr 28, 2024 · 90f651a · 90f651a
2 parents ca870ef + 8f6c630
commit 90f651a
Show file tree

Hide file tree

Showing 25 changed files with 89 additions and 173 deletions.
diff --git a/src/Bridge/Telescope/TelescopeLogger.php b/src/Bridge/Telescope/TelescopeLogger.php
@@ -10,7 +10,7 @@
 
 class TelescopeLogger implements LoggerInterface
 {
-    private LoggerInterface $parentLogger;
+    private readonly LoggerInterface $parentLogger;
 
     public function __construct($parentLogger)
     {

diff --git a/tests/app/Entities/Footprint.php b/tests/app/Entities/Footprint.php
@@ -15,11 +15,11 @@
 
 final class Footprint implements JsonSerializable, Stringable
 {
-    private UserId $id;
+    private readonly UserId $id;
 
-    private string $party;
+    private readonly string $party;
 
-    private string $realm;
+    private readonly string $realm;
 
     public static function empty(string $authorizedParty = 'guest-party', string $realm = 'guest-realm'): self
     {

diff --git a/tests/app/Entities/Post.php b/tests/app/Entities/Post.php
@@ -18,10 +18,10 @@ class Post
     public int $id;
 
     #[Column(type: 'string')]
-    private string $title;
+    private readonly string $title;
 
     #[Column(type: 'text')]
-    private string $description;
+    private readonly string $description;
 
     #[Column(type: 'datetime', nullable: true)]
     private ?DateTimeImmutable $deletedAt = null;

diff --git a/tests/app/Entities/UserId.php b/tests/app/Entities/UserId.php
@@ -9,7 +9,7 @@
 
 final class UserId implements Stringable
 {
-    private string $id;
+    private readonly string $id;
 
     public static function create(string $userId): self
     {

diff --git a/tests/src/Bridge/Laravel/Console/Commands/Database/ListCommandTest.php b/tests/src/Bridge/Laravel/Console/Commands/Database/ListCommandTest.php
@@ -7,13 +7,12 @@
 use Cycle\Database\Database;
 use Cycle\Database\DatabaseInterface;
 use Illuminate\Support\Facades\Artisan;
+use PHPUnit\Framework\Attributes\Test;
 use WayOfDev\Tests\TestCase;
 
 class ListCommandTest extends TestCase
 {
-    /**
-     * @test
-     */
+    #[Test]
     public function it_runs_handle(): void
     {
         /** @var Database $database */

diff --git a/tests/src/Bridge/Laravel/Console/Commands/Database/TableCommandTest.php b/tests/src/Bridge/Laravel/Console/Commands/Database/TableCommandTest.php
@@ -7,13 +7,12 @@
 use Cycle\Database\Database;
 use Cycle\Database\DatabaseInterface;
 use Illuminate\Support\Facades\Artisan;
+use PHPUnit\Framework\Attributes\Test;
 use WayOfDev\Tests\TestCase;
 
 class TableCommandTest extends TestCase
 {
-    /**
-     * @test
-     */
+    #[Test]
     public function it_runs_handle(): void
     {
         /** @var Database $database */

diff --git a/tests/src/Bridge/Laravel/Console/Commands/Migrations/InitCommandTest.php b/tests/src/Bridge/Laravel/Console/Commands/Migrations/InitCommandTest.php
@@ -6,13 +6,12 @@
 
 use Cycle\Database\Database;
 use Cycle\Database\DatabaseInterface;
+use PHPUnit\Framework\Attributes\Test;
 use WayOfDev\Tests\TestCase;
 
 class InitCommandTest extends TestCase
 {
-    /**
-     * @test
-     */
+    #[Test]
     public function it_runs_handle(): void
     {
         /** @var Database $database */

diff --git a/tests/src/Bridge/Laravel/Console/Commands/Migrations/MigrateCommandTest.php b/tests/src/Bridge/Laravel/Console/Commands/Migrations/MigrateCommandTest.php
@@ -6,13 +6,12 @@
 
 use Cycle\Database\Database;
 use Cycle\Database\DatabaseInterface;
+use PHPUnit\Framework\Attributes\Test;
 use WayOfDev\Tests\TestCase;
 
 class MigrateCommandTest extends TestCase
 {
-    /**
-     * @test
-     */
+    #[Test]
     public function it_migrates_in_safe_environment(): void
     {
         /** @var Database $database */
@@ -27,9 +26,7 @@ public function it_migrates_in_safe_environment(): void
         $this::assertCount(1, $database->getTables());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function it_migrates_in_production_with_force_option(): void
     {
         // Set the application environment to production
@@ -50,9 +47,7 @@ public function it_migrates_in_production_with_force_option(): void
         $this::assertCount(4, $database->getTables());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function it_warns_about_unsafe_migrations(): void
     {
         // Set the application environment to production

diff --git a/tests/src/Bridge/Laravel/Console/Commands/Migrations/ReplayCommandTest.php b/tests/src/Bridge/Laravel/Console/Commands/Migrations/ReplayCommandTest.php
@@ -6,13 +6,12 @@
 
 use Cycle\Database\Database;
 use Cycle\Database\DatabaseInterface;
+use PHPUnit\Framework\Attributes\Test;
 use WayOfDev\Tests\TestCase;
 
 class ReplayCommandTest extends TestCase
 {
-    /**
-     * @test
-     */
+    #[Test]
     public function it_runs_handle(): void
     {
         /** @var Database $database */

diff --git a/tests/src/Bridge/Laravel/Console/Commands/Migrations/RollbackCommandTest.php b/tests/src/Bridge/Laravel/Console/Commands/Migrations/RollbackCommandTest.php
@@ -6,13 +6,12 @@
 
 use Cycle\Database\Database;
 use Cycle\Database\DatabaseInterface;
+use PHPUnit\Framework\Attributes\Test;
 use WayOfDev\Tests\TestCase;
 
 class RollbackCommandTest extends TestCase
 {
-    /**
-     * @test
-     */
+    #[Test]
     public function it_runs_handle(): void
     {
         /** @var Database $database */

diff --git a/tests/src/Bridge/Laravel/Console/Commands/Migrations/StatusCommandTest.php b/tests/src/Bridge/Laravel/Console/Commands/Migrations/StatusCommandTest.php
@@ -7,13 +7,12 @@
 use Cycle\Database\Database;
 use Cycle\Database\DatabaseInterface;
 use Illuminate\Support\Facades\Artisan;
+use PHPUnit\Framework\Attributes\Test;
 use WayOfDev\Tests\TestCase;
 
 class StatusCommandTest extends TestCase
 {
-    /**
-     * @test
-     */
+    #[Test]
     public function it_runs_handle(): void
     {
         /** @var Database $database */

diff --git a/tests/src/Bridge/Laravel/Console/Commands/ORM/MigrateCommandTest.php b/tests/src/Bridge/Laravel/Console/Commands/ORM/MigrateCommandTest.php
@@ -6,6 +6,7 @@
 
 use Cycle\ORM\SchemaInterface;
 use Illuminate\Support\Facades\File;
+use PHPUnit\Framework\Attributes\Test;
 use Psr\Container\ContainerExceptionInterface;
 use Psr\Container\NotFoundExceptionInterface;
 use WayOfDev\Cycle\Contracts\CacheManager;
@@ -34,9 +35,7 @@ protected function setUp(): void
         File::delete(__DIR__ . '/../../../../../../app/Entities/Tag.php');
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function it_runs_migrate(): void
     {
         $this->assertConsoleCommandOutputContainsStrings('cycle:orm:migrate', ['-n' => true], self::USER_MIGRATION);
@@ -46,9 +45,7 @@ public function it_runs_migrate(): void
         ]);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function it_runs_migrate_with_no_changes(): void
     {
         $this->artisanCall('cycle:orm:migrate', ['-n' => true]);
@@ -58,9 +55,7 @@ public function it_runs_migrate_with_no_changes(): void
         $this->assertConsoleCommandOutputContainsStrings('cycle:orm:migrate', [], 'No database changes');
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function it_creates_migration_when_entity_appeared(): void
     {
         $this->assertConsoleCommandOutputContainsStrings('cycle:orm:migrate', ['-r' => true], self::USER_MIGRATION);
@@ -98,11 +93,10 @@ class Tag
     }
 
     /**
-     * @test
-     *
      * @throws ContainerExceptionInterface
      * @throws NotFoundExceptionInterface
      */
+    #[Test]
     public function it_passes_schema_defaults_to_compiler(): void
     {
         config()->set('cycle.schema.defaults', [

diff --git a/tests/src/Bridge/Laravel/Console/Commands/ORM/RenderCommandTest.php b/tests/src/Bridge/Laravel/Console/Commands/ORM/RenderCommandTest.php
@@ -6,13 +6,12 @@
 
 use Cycle\ORM\Parser\Typecast;
 use Cycle\ORM\SchemaInterface;
+use PHPUnit\Framework\Attributes\Test;
 use WayOfDev\Tests\TestCase;
 
 class RenderCommandTest extends TestCase
 {
-    /**
-     * @test
-     */
+    #[Test]
     public function it_runs_handle(): void
     {
         $this->assertConsoleCommandOutputContainsStrings('cycle:orm:render', ['--no-color' => true], [

diff --git a/tests/src/Bridge/Laravel/Console/Commands/ORM/SyncCommandTest.php b/tests/src/Bridge/Laravel/Console/Commands/ORM/SyncCommandTest.php
@@ -6,17 +6,17 @@
 
 use Cycle\ORM\EntityManager;
 use Illuminate\Support\Facades\Artisan;
+use PHPUnit\Framework\Attributes\Test;
 use Throwable;
 use WayOfDev\App\Entities\User;
 use WayOfDev\Tests\TestCase;
 
 class SyncCommandTest extends TestCase
 {
     /**
-     * @test
-     *
      * @throws Throwable
      */
+    #[Test]
     public function it_runs_handle(): void
     {
         $this->artisanCall('cycle:orm:sync');
@@ -31,10 +31,9 @@ public function it_runs_handle(): void
     }
 
     /**
-     * @test
-     *
      * @throws Throwable
      */
+    #[Test]
     public function it_runs_handle_in_debug_mode(): void
     {
         $this->assertConsoleCommandOutputContainsStrings('cycle:orm:sync', ['--verbose' => 3], [
@@ -50,9 +49,7 @@ public function it_runs_handle_in_debug_mode(): void
         $this::assertSame(1, $u->id);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function it_fails_in_production_without_force(): void
     {
         // Set the application environment to production

diff --git a/tests/src/Bridge/Laravel/Console/Commands/ORM/UpdateCommandTest.php b/tests/src/Bridge/Laravel/Console/Commands/ORM/UpdateCommandTest.php
@@ -5,14 +5,13 @@
 namespace WayOfDev\Tests\Bridge\Laravel\Console\Commands\ORM;
 
 use Cycle\ORM\SchemaInterface;
+use PHPUnit\Framework\Attributes\Test;
 use WayOfDev\App\Entities\User;
 use WayOfDev\Tests\TestCase;
 
 class UpdateCommandTest extends TestCase
 {
-    /**
-     * @test
-     */
+    #[Test]
     public function it_runs_handle(): void
     {
         $this->artisanCall('cycle:orm');

diff --git a/tests/src/Bridge/Laravel/LoggerFactoryTest.php b/tests/src/Bridge/Laravel/LoggerFactoryTest.php
@@ -12,6 +12,7 @@
 use Illuminate\Log\LogManager;
 use Illuminate\Support\Facades\Event;
 use Mockery as m;
+use PHPUnit\Framework\Attributes\Test;
 use Psr\Container\ContainerExceptionInterface;
 use Psr\Container\NotFoundExceptionInterface;
 use Psr\Log\NullLogger;
@@ -31,11 +32,10 @@ protected function tearDown(): void
     }
 
     /**
-     * @test
-     *
      * @throws ContainerExceptionInterface
      * @throws NotFoundExceptionInterface
      */
+    #[Test]
     public function it_should_return_custom_logger_from_factory(): void
     {
         $this->app['config']->set('cycle.database.logger.use_telescope', false);
@@ -58,11 +58,10 @@ public function it_should_return_custom_logger_from_factory(): void
     }
 
     /**
-     * @test
-     *
      * @throws ContainerExceptionInterface
      * @throws NotFoundExceptionInterface
      */
+    #[Test]
     public function it_should_fire_query_executed_event_when_query_is_logged(): void
     {
         $this->app['config']->set('cycle.database.logger.use_telescope', true);
@@ -84,11 +83,10 @@ public function it_should_fire_query_executed_event_when_query_is_logged(): void
     }
 
     /**
-     * @test
-     *
      * @throws ContainerExceptionInterface
      * @throws NotFoundExceptionInterface
      */
+    #[Test]
     public function it_should_return_null_logger_from_factory(): void
     {
         config()->set('cycle.database.logger', [