Ignore tags with null attributes

Fixes an edge case that occurs when used with vue-cli. Closes #122
waysact · Apr 29, 2020 · b616def · b616def
1 parent f47a7a2
commit b616def
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/test/test-misc.js b/test/test-misc.js
@@ -17,6 +17,8 @@ var webpackVersion = Number(
   require('webpack/package.json').version.split('.')[0]
 );
 
+var util = require('../util');
+
 function testCompilation() {
   return {
     warnings: [],
@@ -311,4 +313,8 @@ describe('Plugin Options', function describe() {
     expect(dummyCompilation.warnings[0].message).toMatch(
         /Set webpack option output.crossOriginLoading/);
   });
+
+  it('ignores tags without attributes', function it() {
+    expect(util.filterTag({ tagName: "script" })).toBeFalsy();
+  });
 });
diff --git a/util.js b/util.js
@@ -67,7 +67,11 @@ function getTagSrc(tag) {
 
 function filterTag(tag) {
   // Process only script and link tags with a url
-  return (tag.tagName === "script" || tag.tagName === "link") && getTagSrc(tag);
+  return (
+    (tag.tagName === "script" || tag.tagName === "link") &&
+    tag.attributes &&
+    getTagSrc(tag)
+  );
 }
 
 function normalizePath(p) {