wait for register status for incall #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reason: for now it only cause problem on incall (with slow host), so maybe in the future we will need to check for internal phone too in user step
fblackburn1
force-pushed
the
wait-for-register-status
branch
from
5603355
to
4803024
Compare
|
This change depends on a change that failed to merge. |
|
recheck |
1 similar comment
|
recheck |
pc-m
previously approved these changes
Dec 20, 2019
|
Build failed.
|
|
recheck |
|
Build failed.
|
pc-m
previously approved these changes
Dec 20, 2019
|
Build failed.
|
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
recheck |
|
Build failed.
|
fblackburn1
force-pushed
the
wait-for-register-status
branch
from
fec538d
to
26ce09c
Compare
|
Build failed.
|
|
recheck |
|
This change depends on a change that failed to merge. |
fblackburn1
force-pushed
the
wait-for-register-status
branch
from
26ce09c
to
e7f8be8
Compare
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
Build succeeded.
|
pc-m
previously approved these changes
Jan 14, 2020
bloom1
previously approved these changes
Jan 14, 2020
reason: to fix the following issue websocket-client/websocket-client#449 websocket-client/websocket-client#586
reason: it is a know issue that need to be fixed
reason: join_node has been refactored to use another goal. The proper method to use is `make_call_to_node`
fblackburn1
force-pushed
the
wait-for-register-status
branch
from
380899a
to
7717393
Compare
bloom1
approved these changes
Jan 14, 2020
|
Build succeeded.
|
|
Build failed (gate pipeline). For information on how to proceed, see
|
|
regate |
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reason: for now it only cause problem on incall, so maybe in the future
we will need to check for internal phone too in user step
Depends-on: wazo-platform/pylinphonelib#8
Depends-on: wazo-platform/sf-jobs#43